From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6763 invoked by alias); 2 Mar 2006 09:31:50 -0000 Received: (qmail 6751 invoked by uid 22791); 2 Mar 2006 09:31:49 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Thu, 02 Mar 2006 09:31:47 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 29A6A544001; Thu, 2 Mar 2006 10:31:45 +0100 (CET) Date: Thu, 02 Mar 2006 09:31:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: Re: [RFA] mn10300-tdep.c: Always write return address to MDR register on push_dummy_call Message-ID: <20060302093144.GA3184@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org References: <20060301172752.GV3184@calimero.vinschen.de> <4406037A.6020307@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4406037A.6020307@redhat.com> User-Agent: Mutt/1.4.2i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00047.txt.bz2 On Mar 1 12:26, Michael Snyder wrote: > Corinna Vinschen wrote: > >Hi, > > > >the mn10300 hardware always writes the return address to the stack and > >into the MDR register when any "call" machine instruction is executed. > >The mn10300_push_dummy_call function does only write the return address > >to the stack, which might result into problems when leaf functions are > >called and the MDR register is known not to be clobbered by "mul" or > >"div" instructions. The below patch also writes the return address > >always into the MDR register, like the hardware. > > > >Ok to apply? > > Ha, yes, nice catch. ;-) Thanks, applied. > > * mn10300-tdep.c (mn10300_push_dummy_call): Write breakpoint > > address to MDR register. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat