From: Daniel Jacobowitz <drow@false.org>
To: Randolph Chung <randolph@tausq.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] hpread.c cleanups
Date: Wed, 01 Mar 2006 17:30:00 -0000 [thread overview]
Message-ID: <20060301173034.GA6465@nevyn.them.org> (raw)
In-Reply-To: <4405380F.2090202@tausq.org>
On Wed, Mar 01, 2006 at 01:58:39PM +0800, Randolph Chung wrote:
> The hppa target used to use a objfile private field to store some shared
> object information on HPUX. Most of that have been cleaned up, but there
> is one more instance in hpread.c. In fact, the current code in cvs will
> cause a crash because the objfile private field is not initialized. The
> patch changes hpread.c to use the solist interface. Tested lightly on
> hppa64-hp-hpux11.11. OK?
> 2006-03-01 Randolph Chung <tausq@debian.org>
>
> * hpread.c (hpread_process_one_debug_symbol): Use solist interface to
> retrieve shared object information.
> * hppa-tdep.h (hppa_objfile_private): Remove unused so_info field.
> * Makefile.in (hpread.o): Update dependencies.
It looks plausible to me, but you may want to check with Kevin if using
solist.h this way is OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-03-01 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-01 5:58 Randolph Chung
2006-03-01 17:30 ` Daniel Jacobowitz [this message]
2006-03-27 0:35 ` Randolph Chung
2006-03-01 21:02 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301173034.GA6465@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=randolph@tausq.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox