From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26779 invoked by alias); 1 Mar 2006 17:30:41 -0000 Received: (qmail 26771 invoked by uid 22791); 1 Mar 2006 17:30:40 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 01 Mar 2006 17:30:39 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1FEV9m-0001hL-AM; Wed, 01 Mar 2006 12:30:34 -0500 Date: Wed, 01 Mar 2006 17:30:00 -0000 From: Daniel Jacobowitz To: Randolph Chung Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] hpread.c cleanups Message-ID: <20060301173034.GA6465@nevyn.them.org> Mail-Followup-To: Randolph Chung , gdb-patches@sources.redhat.com References: <4405380F.2090202@tausq.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4405380F.2090202@tausq.org> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-03/txt/msg00011.txt.bz2 On Wed, Mar 01, 2006 at 01:58:39PM +0800, Randolph Chung wrote: > The hppa target used to use a objfile private field to store some shared > object information on HPUX. Most of that have been cleaned up, but there > is one more instance in hpread.c. In fact, the current code in cvs will > cause a crash because the objfile private field is not initialized. The > patch changes hpread.c to use the solist interface. Tested lightly on > hppa64-hp-hpux11.11. OK? > 2006-03-01 Randolph Chung > > * hpread.c (hpread_process_one_debug_symbol): Use solist interface to > retrieve shared object information. > * hppa-tdep.h (hppa_objfile_private): Remove unused so_info field. > * Makefile.in (hpread.o): Update dependencies. It looks plausible to me, but you may want to check with Kevin if using solist.h this way is OK. -- Daniel Jacobowitz CodeSourcery