Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Mitchell <mark@codesourcery.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: PowerPC simulator doesn't handle spaces in filenames
Date: Tue, 24 Jan 2006 21:24:00 -0000	[thread overview]
Message-ID: <20060124212444.GD26974@nevyn.them.org> (raw)
In-Reply-To: <200601240559.k0O5xhER007274@sethra.codesourcery.com>

On Mon, Jan 23, 2006 at 09:59:43PM -0800, Mark Mitchell wrote:
> 
> The PowerPC simulator simulates bits of openprom functionality.  In
> particular, it feeds the program file name into the openprom device
> tree.  However, filenames containing a space or backslash (both of
> which are very common on Windows, but can also occur on UNIX), were
> not quoted.  (Here, quoting means enclosing the entire filename in
> double-quotes, and protecting backslashes by double-quoting them.)
> 
> Tested by verifying that I could run a PowerPC program with a space
> and/or backslash in its name, on both x86_64-unknown-linux-gnu and
> i686-mingw32. 
> 
> OK?

You've escaped backslashes, but what about double quotes?  I assume
this eventually goes to parse_string_property.  It's not immediately
obvious, but the unescaping loop there will unescape both backslashes
and double quotes (see print_string).

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2006-01-24 21:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-24  5:59 Mark Mitchell
2006-01-24 21:24 ` Daniel Jacobowitz [this message]
2006-01-25  6:23   ` Mark Mitchell
2006-02-02  1:44     ` Daniel Jacobowitz
2006-02-02  6:50       ` Mark Mitchell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060124212444.GD26974@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mark@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox