From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25692 invoked by alias); 24 Jan 2006 21:24:49 -0000 Received: (qmail 25684 invoked by uid 22791); 24 Jan 2006 21:24:48 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 24 Jan 2006 21:24:47 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1F1Vee-0007A0-U6; Tue, 24 Jan 2006 16:24:45 -0500 Date: Tue, 24 Jan 2006 21:24:00 -0000 From: Daniel Jacobowitz To: Mark Mitchell Cc: gdb-patches@sources.redhat.com Subject: Re: PATCH: PowerPC simulator doesn't handle spaces in filenames Message-ID: <20060124212444.GD26974@nevyn.them.org> Mail-Followup-To: Mark Mitchell , gdb-patches@sources.redhat.com References: <200601240559.k0O5xhER007274@sethra.codesourcery.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601240559.k0O5xhER007274@sethra.codesourcery.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00375.txt.bz2 On Mon, Jan 23, 2006 at 09:59:43PM -0800, Mark Mitchell wrote: > > The PowerPC simulator simulates bits of openprom functionality. In > particular, it feeds the program file name into the openprom device > tree. However, filenames containing a space or backslash (both of > which are very common on Windows, but can also occur on UNIX), were > not quoted. (Here, quoting means enclosing the entire filename in > double-quotes, and protecting backslashes by double-quoting them.) > > Tested by verifying that I could run a PowerPC program with a space > and/or backslash in its name, on both x86_64-unknown-linux-gnu and > i686-mingw32. > > OK? You've escaped backslashes, but what about double quotes? I assume this eventually goes to parse_string_property. It's not immediately obvious, but the unescaping loop there will unescape both backslashes and double quotes (see print_string). -- Daniel Jacobowitz CodeSourcery