Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Bob Rossi <bob@brasko.net>
To: Vladimir Prus <ghost@cs.msu.su>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Add fullname field for MI -break-info command
Date: Tue, 24 Jan 2006 16:51:00 -0000	[thread overview]
Message-ID: <20060124165136.GF28357@brasko.net> (raw)
In-Reply-To: <200601241932.16022.ghost@cs.msu.su>

On Tue, Jan 24, 2006 at 07:32:15PM +0300, Vladimir Prus wrote:
> 
> Hello!
> 
> The attached patch adds the "fullname" field to the output of MI -break-info
> command.

The patch seems good to me at first glance. However, you should also
update the testsuite, and send in the patch for that as well.

Also, don't forget about the documentation.

Thanks,
Bob Rossi


  reply	other threads:[~2006-01-24 16:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-24 16:42 Vladimir Prus
2006-01-24 16:51 ` Bob Rossi [this message]
2006-01-25 11:07   ` Vladimir Prus
2006-01-25 12:10     ` Bob Rossi
2006-01-25 12:37       ` Andreas Schwab
2006-01-25 12:50       ` Vladimir Prus
2006-01-25 13:45         ` Bob Rossi
2006-01-26  7:10           ` Vladimir Prus
2006-01-28 13:10   ` Vladimir Prus
2006-02-01 22:32     ` Daniel Jacobowitz
2006-02-02  7:07       ` Vladimir Prus
2006-02-06 21:55         ` Daniel Jacobowitz
2006-01-24 21:13 ` Daniel Jacobowitz
2006-01-25 13:31   ` Vladimir Prus
2006-01-25 13:46     ` Bob Rossi
2006-01-26  7:20       ` Vladimir Prus
2006-01-25 13:51     ` Daniel Jacobowitz
2006-01-25 17:56     ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2006-01-26 11:27 Nick Roberts
2006-01-26 11:44 ` Vladimir Prus
2006-01-26  7:13 Nick Roberts
2006-01-26  7:06 Nick Roberts
2006-01-24 16:42 Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060124165136.GF28357@brasko.net \
    --to=bob@brasko.net \
    --cc=gdb-patches@sources.redhat.com \
    --cc=ghost@cs.msu.su \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox