From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9779 invoked by alias); 24 Jan 2006 16:51:08 -0000 Received: (qmail 9766 invoked by uid 22791); 24 Jan 2006 16:51:07 -0000 X-Spam-Check-By: sourceware.org Received: from eastrmmtao04.cox.net (HELO eastrmmtao04.cox.net) (68.230.240.35) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 24 Jan 2006 16:51:06 +0000 Received: from localhost.localdomain ([68.9.66.48]) by eastrmmtao04.cox.net (InterMail vM.6.01.05.02 201-2131-123-102-20050715) with ESMTP id <20060124165107.XYNM19943.eastrmmtao04.cox.net@localhost.localdomain>; Tue, 24 Jan 2006 11:51:07 -0500 Received: from bob by localhost.localdomain with local (Exim 4.52) id 1F1ROK-00054w-KJ; Tue, 24 Jan 2006 11:51:36 -0500 Date: Tue, 24 Jan 2006 16:51:00 -0000 From: Bob Rossi To: Vladimir Prus Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Add fullname field for MI -break-info command Message-ID: <20060124165136.GF28357@brasko.net> Mail-Followup-To: Vladimir Prus , gdb-patches@sources.redhat.com References: <200601241932.16022.ghost@cs.msu.su> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200601241932.16022.ghost@cs.msu.su> User-Agent: Mutt/1.5.9i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00358.txt.bz2 On Tue, Jan 24, 2006 at 07:32:15PM +0300, Vladimir Prus wrote: > > Hello! > > The attached patch adds the "fullname" field to the output of MI -break-info > command. The patch seems good to me at first glance. However, you should also update the testsuite, and send in the patch for that as well. Also, don't forget about the documentation. Thanks, Bob Rossi