Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: Obvious: gdb_byte changes for dwarf2read.c
Date: Tue, 17 Jan 2006 22:09:00 -0000	[thread overview]
Message-ID: <20060117220922.GA14556@nevyn.them.org> (raw)
In-Reply-To: <8f2776cb0601171405r58f4494ek4481ca4253099d7e@mail.gmail.com>

On Tue, Jan 17, 2006 at 02:05:03PM -0800, Jim Blandy wrote:
> gdb/ChangeLog:
> 2006-01-17  Jim Blandy  <jimb@redhat.com>
> 
> 	* dwarf2read.c (struct dwarf2_per_objfile, struct comp_unit_head)
> 	(struct line_header, struct partial_die_info, struct dwarf_block):
> 	Use gdb_byte for members that refer to Dwarf section contents.
> 	(dwarf2_read_abbrevs, dwarf2_read_section, dwarf_decode_lines,
> 	dwarf_decode_macros, load_comp_unit, load_partial_dies,
> 	locate_pdi_sibling, partial_read_comp_unit_head, peek_die_abbrev,
> 	read_1_byte, read_1_signed_byte, read_2_bytes, read_4_bytes,
> 	read_8_bytes, read_address, read_attribute, read_attribute_value,
> 	read_comp_unit, read_comp_unit_head, read_die_and_children,
> 	read_die_and_siblings, read_full_die, read_indirect_string,
> 	read_initial_length, read_n_bytes, read_offset, read_partial_die,
> 	read_signed_leb128, read_string, read_unsigned_leb128,
> 	skip_children, skip_leb128, skip_one_die): Same.

Yay!  Thanks, Jim.

While I'm not sure it's worth doing this to every symbol reader, it is
a lot clearer to read than using char* everywhere.

-- 
Daniel Jacobowitz
CodeSourcery


      reply	other threads:[~2006-01-17 22:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-17 22:05 Jim Blandy
2006-01-17 22:09 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060117220922.GA14556@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox