From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24653 invoked by alias); 17 Jan 2006 22:09:37 -0000 Received: (qmail 24626 invoked by uid 22791); 17 Jan 2006 22:09:36 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Tue, 17 Jan 2006 22:09:33 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Eyz10-0003nh-3u for gdb-patches@sources.redhat.com; Tue, 17 Jan 2006 17:09:22 -0500 Date: Tue, 17 Jan 2006 22:09:00 -0000 From: Daniel Jacobowitz To: GDB Patches Subject: Re: Obvious: gdb_byte changes for dwarf2read.c Message-ID: <20060117220922.GA14556@nevyn.them.org> Mail-Followup-To: GDB Patches References: <8f2776cb0601171405r58f4494ek4481ca4253099d7e@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f2776cb0601171405r58f4494ek4481ca4253099d7e@mail.gmail.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00230.txt.bz2 On Tue, Jan 17, 2006 at 02:05:03PM -0800, Jim Blandy wrote: > gdb/ChangeLog: > 2006-01-17 Jim Blandy > > * dwarf2read.c (struct dwarf2_per_objfile, struct comp_unit_head) > (struct line_header, struct partial_die_info, struct dwarf_block): > Use gdb_byte for members that refer to Dwarf section contents. > (dwarf2_read_abbrevs, dwarf2_read_section, dwarf_decode_lines, > dwarf_decode_macros, load_comp_unit, load_partial_dies, > locate_pdi_sibling, partial_read_comp_unit_head, peek_die_abbrev, > read_1_byte, read_1_signed_byte, read_2_bytes, read_4_bytes, > read_8_bytes, read_address, read_attribute, read_attribute_value, > read_comp_unit, read_comp_unit_head, read_die_and_children, > read_die_and_siblings, read_full_die, read_indirect_string, > read_initial_length, read_n_bytes, read_offset, read_partial_die, > read_signed_leb128, read_string, read_unsigned_leb128, > skip_children, skip_leb128, skip_one_die): Same. Yay! Thanks, Jim. While I'm not sure it's worth doing this to every symbol reader, it is a lot clearer to read than using char* everywhere. -- Daniel Jacobowitz CodeSourcery