From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: Fix non-pointer-sign gcc warnings
Date: Mon, 16 Jan 2006 13:42:00 -0000 [thread overview]
Message-ID: <20060116134252.GA31319@nevyn.them.org> (raw)
In-Reply-To: <8f2776cb0601152304h6b7ffefen572b27f268468fc6@mail.gmail.com>
On Sun, Jan 15, 2006 at 11:04:42PM -0800, Jim Blandy wrote:
> On 1/15/06, Daniel Jacobowitz <drow@false.org> wrote:
> > The one in macroexp.c is not a real bug but I think GCC is justified in
> > not being able to see through it. The one in stabsread.c is a real bug
> > and would cause GDB to crash on bad stabs.
>
> Would it make more sense to have gather_arguments actually always
> assign something to *ARGC_P? This would treat *ARGC_P as more like
> part of the return value, which is how I see it.
I don't know; the "leave reference arguments alone on error" behavior
is a pretty common convention in C, and somebody went to the trouble of
documenting it above the function - looks like it was you :-)
Either way makes sense.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-01-16 13:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-15 20:28 Daniel Jacobowitz
2006-01-16 7:04 ` Jim Blandy
2006-01-16 13:42 ` Daniel Jacobowitz [this message]
2006-01-16 22:22 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060116134252.GA31319@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox