From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16122 invoked by alias); 16 Jan 2006 13:42:58 -0000 Received: (qmail 16112 invoked by uid 22791); 16 Jan 2006 13:42:58 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Mon, 16 Jan 2006 13:42:55 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EyUdJ-0008B2-IY for gdb-patches@sourceware.org; Mon, 16 Jan 2006 08:42:53 -0500 Date: Mon, 16 Jan 2006 13:42:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: Fix non-pointer-sign gcc warnings Message-ID: <20060116134252.GA31319@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <20060115202850.GB12204@nevyn.them.org> <8f2776cb0601152304h6b7ffefen572b27f268468fc6@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8f2776cb0601152304h6b7ffefen572b27f268468fc6@mail.gmail.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00194.txt.bz2 On Sun, Jan 15, 2006 at 11:04:42PM -0800, Jim Blandy wrote: > On 1/15/06, Daniel Jacobowitz wrote: > > The one in macroexp.c is not a real bug but I think GCC is justified in > > not being able to see through it. The one in stabsread.c is a real bug > > and would cause GDB to crash on bad stabs. > > Would it make more sense to have gather_arguments actually always > assign something to *ARGC_P? This would treat *ARGC_P as more like > part of the return value, which is how I see it. I don't know; the "leave reference arguments alone on error" behavior is a pretty common convention in C, and somebody went to the trouble of documenting it above the function - looks like it was you :-) Either way makes sense. -- Daniel Jacobowitz CodeSourcery