From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@redhat.com>
Cc: Andrew STUBBS <andrew.stubbs@st.com>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Disable thread specific breakpoints when thread dies
Date: Fri, 13 Jan 2006 04:31:00 -0000 [thread overview]
Message-ID: <20060113043126.GA32398@nevyn.them.org> (raw)
In-Reply-To: <43C729FA.2020500@redhat.com>
On Thu, Jan 12, 2006 at 08:18:02PM -0800, Michael Snyder wrote:
> Daniel,
>
> valid_thread_id wouldn't be safe, because thread ids might be re-used.
>
> This implementation looks fine to me...
How is this any better in that case? These thread IDs can't be reused
without all the rest of GDB having the same problem - this is GDB's
internal thread ID, not the inferior PTID (see the valid_thread_id
implementation).
From Andrew's message it sounds like a missing clear of the thread list
at inferior exit. Which I thought someone had fixed just recently.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2006-01-13 4:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 19:06 Andrew STUBBS
2005-11-13 21:13 ` Daniel Jacobowitz
2005-11-14 16:34 ` Andrew STUBBS
2005-11-14 17:11 ` Daniel Jacobowitz
2005-11-15 18:55 ` Andrew STUBBS
2005-11-16 16:23 ` Andrew STUBBS
2005-11-17 4:22 ` Daniel Jacobowitz
2005-11-17 16:34 ` Andrew STUBBS
2006-01-12 16:25 ` Andrew STUBBS
2006-01-13 4:19 ` Michael Snyder
2006-01-13 4:31 ` Daniel Jacobowitz [this message]
2006-01-12 16:27 ` Daniel Jacobowitz
2006-01-13 17:35 ` Andrew STUBBS
2006-01-13 20:11 ` Mark Kettenis
2006-01-14 15:46 ` Daniel Jacobowitz
2006-01-14 15:56 ` Mark Kettenis
2006-01-14 16:06 ` Daniel Jacobowitz
2006-01-16 12:57 ` Andrew STUBBS
2006-01-16 16:19 ` Andrew STUBBS
2006-01-20 14:56 ` Andrew STUBBS
2006-01-20 15:00 ` Daniel Jacobowitz
2006-01-20 22:41 ` Daniel Jacobowitz
2006-02-02 2:30 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060113043126.GA32398@nevyn.them.org \
--to=drow@false.org \
--cc=andrew.stubbs@st.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox