From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22540 invoked by alias); 13 Jan 2006 04:31:34 -0000 Received: (qmail 22532 invoked by uid 22791); 13 Jan 2006 04:31:34 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Fri, 13 Jan 2006 04:31:31 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1ExGb0-0008RO-Ss; Thu, 12 Jan 2006 23:31:26 -0500 Date: Fri, 13 Jan 2006 04:31:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: Andrew STUBBS , gdb-patches@sources.redhat.com Subject: Re: [PATCH] Disable thread specific breakpoints when thread dies Message-ID: <20060113043126.GA32398@nevyn.them.org> Mail-Followup-To: Michael Snyder , Andrew STUBBS , gdb-patches@sources.redhat.com References: <43723446.7000903@st.com> <20051113184515.GG3599@nevyn.them.org> <437875B0.4000007@st.com> <20051114155659.GA25717@nevyn.them.org> <437A19DE.6040905@st.com> <437B47A1.4040705@st.com> <20051117034811.GB3057@nevyn.them.org> <437CA66B.9060201@st.com> <43C6825C.9020909@st.com> <43C729FA.2020500@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43C729FA.2020500@redhat.com> User-Agent: Mutt/1.5.8i X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-01/txt/msg00138.txt.bz2 On Thu, Jan 12, 2006 at 08:18:02PM -0800, Michael Snyder wrote: > Daniel, > > valid_thread_id wouldn't be safe, because thread ids might be re-used. > > This implementation looks fine to me... How is this any better in that case? These thread IDs can't be reused without all the rest of GDB having the same problem - this is GDB's internal thread ID, not the inferior PTID (see the valid_thread_id implementation). >From Andrew's message it sounds like a missing clear of the thread list at inferior exit. Which I thought someone had fixed just recently. -- Daniel Jacobowitz CodeSourcery