From: Joel Brobecker <brobecker@adacore.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] implement gcore on hp/ux
Date: Wed, 11 Jan 2006 03:59:00 -0000 [thread overview]
Message-ID: <20060111035929.GF878@adacore.com> (raw)
In-Reply-To: <200601102029.k0AKTfPh011880@elgar.sibelius.xs4all.nl>
> I'm not sure I like the exec_set_write_core_file() hack. Targets
> should really do this the proper way, initializing their target vector
> properly. Can't you get rid of it by setting to_write_core_file in
> procfs.c:init_ptoc_ops() and linux-nat.c:linux_target()?
Yes, absolutely. I think I also need to do that for FreeBSD and
probably Solaris too (IIRC), right?
> The HP-UX code looks good, but could you please use xsnprintf()
> instead of sprintf()?
Oops, good catch. Will fix that as well.
Thanks for the review.
--
Joel
next prev parent reply other threads:[~2006-01-11 3:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 17:18 Joel Brobecker
2006-01-10 20:29 ` Mark Kettenis
2006-01-11 3:59 ` Joel Brobecker [this message]
2006-01-12 5:55 ` Joel Brobecker
2006-01-12 20:44 ` Mark Kettenis
2006-01-13 4:25 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060111035929.GF878@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox