From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] implement gcore on hp/ux
Date: Tue, 10 Jan 2006 20:29:00 -0000 [thread overview]
Message-ID: <200601102029.k0AKTfPh011880@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <20060110171752.GL925@adacore.com> (message from Joel Brobecker on Tue, 10 Jan 2006 21:17:52 +0400)
> Date: Tue, 10 Jan 2006 21:17:52 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 2005-01-10 Joel Brobecker <brobecker@adacore.com>
>
> * target.h (target_ops): New method to_write_core_file.
> (target_write_core_file_p): New macro.
> (target_write_core_file): New macro.
> * target.c (update_current_target): Add heritance of to_write_core_file.
> * exec.c (exec_set_write_core_file): New function.
> * defs.h (exec_set_write_core_file): Add declaration.
> * gcore.c: Extract out the code writing the core file and move it
> to gcore-elf.c.
> * gcore-elf.c: New file, mostly extracted from gcore.o.
> * Makefile.in (COMMON_OBS): Add gcore.o.
> (gcore.o): Update dependencies.
> (gcore-elf.o): Add rule.
> * inf-ttrace (inf_ttrace_write_core_file): New function.
> (inf_ttrace_target): set the to_write_core_file method.
> * config/alpha/fbsd.mh (NATDEPFILES): Likewise.
> * config/arm/linux.mh (NATDEPFILES): Likewise.
> * config/i386/fbsd.mh (NATDEPFILES): Likewise.
> * config/i386/fbsd64.mh (NATDEPFILES): Likewise.
> * config/i386/i386sol2.mh (NATDEPFILES): Likewise.
> * config/i386/i386v42mp.mh (NATDEPFILES): Likewise.
> * config/i386/linux.mh (NATDEPFILES): Likewise.
> * config/i386/linux64.mh (NATDEPFILES): Likewise.
> * config/i386/sol2-64.mh (NATDEPFILES): Likewise.
> * config/ia64/linux.mh (NATDEPFILES): Likewise.
> * config/m32r/linux.mh (NATDEPFILES): Likewise.
> * config/m68k/linux.mh (NATDEPFILES): Likewise.
> * config/mips/linux.mh (NATDEPFILES): Likewise.
> * config/pa/linux.mh (NATDEPFILES): Likewise.
> * config/powerpc/linux.mh (NATDEPFILES): Likewise.
> * config/powerpc/ppc64-linux.mh (NATDEPFILES): Likewise.
> * config/s390/s390.mh (NATDEPFILES): Likewise.
> * config/sparc/fbsd.mh (NATDEPFILES): Likewise.
> * config/sparc/linux.mh (NATDEPFILES): Likewise.
> * config/sparc/linux64.mh (NATDEPFILES): Likewise.
> * config/sparc/sol2.mh (NATDEPFILES): Likewise.
>
> Tested on x86-linux and pa32-hpux. No regression on the linux
> side. On the hp/ux side, we get improvments from auxv.exp and
> gcore.exp now passes.
>
> Comments? Ok to apply?
I'm not sure I like the exec_set_write_core_file() hack. Targets
should really do this the proper way, initializing their target vector
properly. Can't you get rid of it by setting to_write_core_file in
procfs.c:init_ptoc_ops() and linux-nat.c:linux_target()?
The HP-UX code looks good, but could you please use xsnprintf()
instead of sprintf()?
Mark
next prev parent reply other threads:[~2006-01-10 20:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-10 17:18 Joel Brobecker
2006-01-10 20:29 ` Mark Kettenis [this message]
2006-01-11 3:59 ` Joel Brobecker
2006-01-12 5:55 ` Joel Brobecker
2006-01-12 20:44 ` Mark Kettenis
2006-01-13 4:25 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601102029.k0AKTfPh011880@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox