Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [commit] spelling errors in rs6000-tdep.c
@ 2005-12-22  4:27 Joel Brobecker
  2005-12-22  4:46 ` Joel Brobecker
  0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2005-12-22  4:27 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

Hello,

Just committed the following patch as obvious.

2005-12-20  Joel Brobecker  <brobecker@adacore.com>

        * rs6000-tdep.c: Fix spelling errors.

-- 
Joel

[-- Attachment #2: spelling.diff --]
[-- Type: text/plain, Size: 1229 bytes --]

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.249
diff -u -p -r1.249 rs6000-tdep.c
--- rs6000-tdep.c	17 Dec 2005 22:34:02 -0000	1.249
+++ rs6000-tdep.c	20 Dec 2005 14:01:27 -0000
@@ -100,8 +100,8 @@ struct rs6000_framedata
 struct reg
   {
     char *name;			/* name of register */
-    unsigned char sz32;		/* size on 32-bit arch, 0 if nonextant */
-    unsigned char sz64;		/* size on 64-bit arch, 0 if nonextant */
+    unsigned char sz32;		/* size on 32-bit arch, 0 if nonexistant */
+    unsigned char sz64;		/* size on 64-bit arch, 0 if nonexistant */
     unsigned char fpr;		/* whether register is floating-point */
     unsigned char pseudo;       /* whether register is pseudo */
     int spr_num;                /* PowerPC SPR number, or -1 if not an SPR.
@@ -3120,7 +3120,7 @@ rs6000_gdbarch_init (struct gdbarch_info
 	wordsize = 4;
     }
 
-  /* Find a candidate among extant architectures.  */
+  /* Find a candidate among existant architectures.  */
   for (arches = gdbarch_list_lookup_by_info (arches, &info);
        arches != NULL;
        arches = gdbarch_list_lookup_by_info (arches->next, &info))

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [commit] spelling errors in rs6000-tdep.c
  2005-12-22  4:27 [commit] spelling errors in rs6000-tdep.c Joel Brobecker
@ 2005-12-22  4:46 ` Joel Brobecker
  2005-12-22  4:56   ` Jim Blandy
  0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2005-12-22  4:46 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]

Hello,

> 2005-12-20  Joel Brobecker  <brobecker@adacore.com>
> 
>         * rs6000-tdep.c: Fix spelling errors.

Kevin told me in private that "extant" was actually a word that exists.
I guess I lost my brain when I saw 3 instances of the same word and yet
didn't even flinch at fixing it. In human factors in aviation, this is
called a set mind, IIRC.

Anyway, Kevin thinks that "existent" is actually better, except that
I spelled it wrong, so asked me to fix that. Here is what I just checked
in.

2005-12-20  Joel Brobecker  <brobecker@adacore.com>

        * rs6000-tdep.c: Use proper spelling for existent.

Sorry about this.
-- 
Joel

[-- Attachment #2: spelling.diff --]
[-- Type: text/plain, Size: 1235 bytes --]

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.250
diff -u -p -r1.250 rs6000-tdep.c
--- rs6000-tdep.c	20 Dec 2005 14:04:20 -0000	1.250
+++ rs6000-tdep.c	20 Dec 2005 17:55:28 -0000
@@ -100,8 +100,8 @@ struct rs6000_framedata
 struct reg
   {
     char *name;			/* name of register */
-    unsigned char sz32;		/* size on 32-bit arch, 0 if nonexistant */
-    unsigned char sz64;		/* size on 64-bit arch, 0 if nonexistant */
+    unsigned char sz32;		/* size on 32-bit arch, 0 if nonexistent */
+    unsigned char sz64;		/* size on 64-bit arch, 0 if nonexistent */
     unsigned char fpr;		/* whether register is floating-point */
     unsigned char pseudo;       /* whether register is pseudo */
     int spr_num;                /* PowerPC SPR number, or -1 if not an SPR.
@@ -3120,7 +3120,7 @@ rs6000_gdbarch_init (struct gdbarch_info
 	wordsize = 4;
     }
 
-  /* Find a candidate among existant architectures.  */
+  /* Find a candidate among existent architectures.  */
   for (arches = gdbarch_list_lookup_by_info (arches, &info);
        arches != NULL;
        arches = gdbarch_list_lookup_by_info (arches->next, &info))

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [commit] spelling errors in rs6000-tdep.c
  2005-12-22  4:46 ` Joel Brobecker
@ 2005-12-22  4:56   ` Jim Blandy
  0 siblings, 0 replies; 3+ messages in thread
From: Jim Blandy @ 2005-12-22  4:56 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

At the risk of bike-shedding...

The fact that "nonexistent" is in regular use doesn't mean that
"existent" is entirely kosher:
http://www.ling.upenn.edu/courses/ling001/mccord.html

In the 'sz' fields, I think "nonexistent" is right: it's zero when the
registers don't exist.

But in rs6000_gdbarch_init, "extant" is a much better word, having the
connotations of "already".

I've committed the attached.

[-- Attachment #2: jimb.gdb-rs6000-extant-doc-fix.patch --]
[-- Type: text/x-patch, Size: 986 bytes --]

gdb/ChangeLog:
2005-12-20  Jim Blandy  <jimb@redhat.com>

	* rs6000-tdep.c (rs6000_gdbarch_init): Doc fix.

Index: gdb/rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.251
diff -c -p -r1.251 rs6000-tdep.c
*** gdb/rs6000-tdep.c	20 Dec 2005 17:57:44 -0000	1.251
--- gdb/rs6000-tdep.c	20 Dec 2005 19:32:44 -0000
*************** rs6000_gdbarch_init (struct gdbarch_info
*** 3120,3126 ****
  	wordsize = 4;
      }
  
!   /* Find a candidate among existent architectures.  */
    for (arches = gdbarch_list_lookup_by_info (arches, &info);
         arches != NULL;
         arches = gdbarch_list_lookup_by_info (arches->next, &info))
--- 3120,3126 ----
  	wordsize = 4;
      }
  
!   /* Find a candidate among extant architectures.  */
    for (arches = gdbarch_list_lookup_by_info (arches, &info);
         arches != NULL;
         arches = gdbarch_list_lookup_by_info (arches->next, &info))

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-12-20 19:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-12-22  4:27 [commit] spelling errors in rs6000-tdep.c Joel Brobecker
2005-12-22  4:46 ` Joel Brobecker
2005-12-22  4:56   ` Jim Blandy

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox