[RFC] fix testsuite/gdb.cp/printmethod

[RFC] fix testsuite/gdb.cp/printmethod

[Christophe LYON]

Hi all,

As I explained in 
http://sources.redhat.com/ml/gdb/2005-11/msg00611.html, I think that the 
gdb.cp/printmethod test somewhat relies on G++ not generating code for 
the nonvirt() method.

I propose the following fix.

Christophe.


2005-12-06    Christophe Lyon <christophe.lyon@st.com>
	* gdb.cp/printmethod.cc (main): call virt() and nonvirt() to
	force code generation for these functions.
	* gdb.cp/printmethod.exp: expect &A::nonvirt() instead of error
	message.


Index: gdb.cp/printmethod.exp
===================================================================
--- gdb.cp/printmethod.exp    (revision 96)
+++ gdb.cp/printmethod.exp    (working copy)
@@ -63,7 +63,7 @@
  # The first of these is for PR gdb/653.

  gdb_test "print theA->virt" "\\$\[0-9\]* = &A::virt\\((void|)\\)" 
"print virtual method."
-gdb_test "print theA->nonvirt" "Cannot take address of a method" "print 
nonvirtual method."
+gdb_test "print theA->nonvirt" "\\$\[0-9\]* = &A::nonvirt\\((void|)\\)" 
"print nonvirtual method."

  gdb_exit
  return 0

Index: gdb.cp/printmethod.cc
===================================================================
--- gdb.cp/printmethod.cc     (revision 96)
+++ gdb.cp/printmethod.cc     (working copy)
@@ -29,6 +29,8 @@
  int main()
  {
    A *theA = new A;
+  theA->virt();
+  theA->nonvirt();

    return 0;                            // breakpoint: constructs-done
  }

Re: [RFC] fix testsuite/gdb.cp/printmethod

[Daniel Jacobowitz]

On Tue, Dec 06, 2005 at 07:10:25PM +0100, Christophe LYON wrote:
> Hi all,
> 
> As I explained in 
> http://sources.redhat.com/ml/gdb/2005-11/msg00611.html, I think that the 
> gdb.cp/printmethod test somewhat relies on G++ not generating code for 
> the nonvirt() method.
> 
> I propose the following fix.
> 
> Christophe.
> 
> 
> 2005-12-06    Christophe Lyon <christophe.lyon@st.com>
> 	* gdb.cp/printmethod.cc (main): call virt() and nonvirt() to
> 	force code generation for these functions.
> 	* gdb.cp/printmethod.exp: expect &A::nonvirt() instead of error
> 	message.

I agree with your conclusions; this is fine.

I've checked it in, with some formatting/copyright tweaks, since I
needed it for the attached followup: the error message previously being
tested for was lousy, let's improve it.


-- 
Daniel Jacobowitz
CodeSourcery, LLC

2005-12-07  Daniel Jacobowitz  <dan@codesourcery.com>

	* valops.c (value_struct_elt): Clarify error message.

2005-12-07  Christophe Lyon  <christophe.lyon@st.com>

	* gdb.cp/printmethod.cc (main): Call virt and nonvirt, to force
	code generation for these functions.
	* gdb.cp/printmethod.exp: Expect "&A::nonvirt()" instead of an
	error message.

Index: valops.c
===================================================================
RCS file: /cvs/src/src/gdb/valops.c,v
retrieving revision 1.161
diff -u -p -r1.161 valops.c
--- valops.c	27 May 2005 04:39:32 -0000	1.161
+++ valops.c	7 Dec 2005 22:49:13 -0000
@@ -1587,7 +1587,7 @@ value_struct_elt (struct value **argp, s
       v = search_struct_method (name, argp, args, 0, static_memfuncp, t);
 
       if (v == (struct value *) - 1)
-	error (_("Cannot take address of a method"));
+	error (_("Cannot take address of method %s."), name);
       else if (v == 0)
 	{
 	  if (TYPE_NFN_FIELDS (t))
Index: testsuite/gdb.cp/printmethod.cc
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/printmethod.cc,v
retrieving revision 1.2
diff -u -p -r1.2 printmethod.cc
--- testsuite/gdb.cp/printmethod.cc	17 Jun 2004 18:30:18 -0000	1.2
+++ testsuite/gdb.cp/printmethod.cc	7 Dec 2005 23:06:43 -0000
@@ -1,6 +1,6 @@
 /* This test script is part of GDB, the GNU debugger.
 
-   Copyright 2002, 2004,
+   Copyright 2002, 2004, 2005
    Free Software Foundation, Inc.
 
    This program is free software; you can redistribute it and/or modify
@@ -29,6 +29,8 @@ public:
 int main()
 {
   A *theA = new A;
+  theA->virt ();
+  theA->nonvirt ();
 
   return 0;				// breakpoint: constructs-done
 }
Index: testsuite/gdb.cp/printmethod.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.cp/printmethod.exp,v
retrieving revision 1.1
diff -u -p -r1.1 printmethod.exp
--- testsuite/gdb.cp/printmethod.exp	23 Aug 2003 03:55:59 -0000	1.1
+++ testsuite/gdb.cp/printmethod.exp	7 Dec 2005 23:06:43 -0000
@@ -1,4 +1,4 @@
-# Copyright 2002, 2003 Free Software Foundation, Inc.
+# Copyright 2002, 2003, 2005 Free Software Foundation, Inc.
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -63,7 +63,7 @@ gdb_continue_to_breakpoint "end of const
 # The first of these is for PR gdb/653.
 
 gdb_test "print theA->virt" "\\$\[0-9\]* = &A::virt\\((void|)\\)" "print virtual method."
-gdb_test "print theA->nonvirt" "Cannot take address of a method" "print nonvirtual method."
+gdb_test "print theA->nonvirt" "\\$\[0-9\]* = &A::nonvirt\\((void|)\\)" "print nonvirtual method."
 
 gdb_exit
 return 0

Re: [RFC] fix testsuite/gdb.cp/printmethod

[Eli Zaretskii]

> Date: Wed, 7 Dec 2005 18:08:07 -0500
> From: Daniel Jacobowitz <drow@false.org>
> Cc: gdb-patches@sources.redhat.com
> 
> I've checked it in, with some formatting/copyright tweaks
[...]
> --- testsuite/gdb.cp/printmethod.cc	17 Jun 2004 18:30:18 -0000	1.2
> +++ testsuite/gdb.cp/printmethod.cc	7 Dec 2005 23:06:43 -0000
> @@ -1,6 +1,6 @@
>  /* This test script is part of GDB, the GNU debugger.
>  
> -   Copyright 2002, 2004,
> +   Copyright 2002, 2004, 2005
>     Free Software Foundation, Inc.

According to the copyright notice rules that RMS just published (they
will probably be available as part of standards.texi or
maintain.texi), we need to have a "(C)" after the word "Copyright".
It's true that we don't have this in most of our files, but we might
as well get started...

Re: [RFC] fix testsuite/gdb.cp/printmethod

[Daniel Jacobowitz]

On Thu, Dec 08, 2005 at 06:38:03AM +0200, Eli Zaretskii wrote:
> > Date: Wed, 7 Dec 2005 18:08:07 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> > Cc: gdb-patches@sources.redhat.com
> > 
> > I've checked it in, with some formatting/copyright tweaks
> [...]
> > --- testsuite/gdb.cp/printmethod.cc	17 Jun 2004 18:30:18 -0000	1.2
> > +++ testsuite/gdb.cp/printmethod.cc	7 Dec 2005 23:06:43 -0000
> > @@ -1,6 +1,6 @@
> >  /* This test script is part of GDB, the GNU debugger.
> >  
> > -   Copyright 2002, 2004,
> > +   Copyright 2002, 2004, 2005
> >     Free Software Foundation, Inc.
> 
> According to the copyright notice rules that RMS just published (they
> will probably be available as part of standards.texi or
> maintain.texi), we need to have a "(C)" after the word "Copyright".
> It's true that we don't have this in most of our files, but we might
> as well get started...

IMO we really should do them all at once.  The other thing we need to
do is update the FSF address; I have had this flagged to take care of
since the FSF moved this spring, but I (obviously) haven't found the
time...

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: [RFC] fix testsuite/gdb.cp/printmethod

[Jim Blandy]

On 12/7/05, Daniel Jacobowitz <drow@false.org> wrote:
> IMO we really should do them all at once.  The other thing we need to
> do is update the FSF address; I have had this flagged to take care of
> since the FSF moved this spring, but I (obviously) haven't found the
> time...

Not to be ultra-noodly, but I've been formatting the FSF street
address as if it were, well, a street address: name, street and
city/zip on separate lines.  I think it looks nice.  We're not working
on 24x80 terminals any more.

Re: [RFC] fix testsuite/gdb.cp/printmethod

[Eli Zaretskii]

> Date: Wed, 7 Dec 2005 23:42:36 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> > According to the copyright notice rules that RMS just published (they
> > will probably be available as part of standards.texi or
> > maintain.texi), we need to have a "(C)" after the word "Copyright".
> > It's true that we don't have this in most of our files, but we might
> > as well get started...
> 
> IMO we really should do them all at once.  The other thing we need to
> do is update the FSF address; I have had this flagged to take care of
> since the FSF moved this spring, but I (obviously) haven't found the
> time...

You are right.  I will try to find time to do this one of these days.

Re: [RFC] fix testsuite/gdb.cp/printmethod

[Mark Kettenis]

> X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on 
> 	elgar.sibelius.xs4all.nl
> X-Spam-Level: 
> X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=no 
> 	version=3.1.0
> X-From_: gdb-patches-return-41882-m.m.kettenis=alumnus.utwente.nl@sourceware.org  Thu Dec  8 05:38:13 2005
> Date: Thu, 08 Dec 2005 06:38:03 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Reply-to: Eli Zaretskii <eliz@gnu.org>
> X-IsSubscribed: yes
> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
> Sender: gdb-patches-owner@sourceware.org
> X-UTwente-MailScanner-Information: Scanned by MailScanner. Contact helpdesk@ITBE.utwente.nl for more information.
> X-UTwente-MailScanner: Found to be clean
> X-MailScanner-From: gdb-patches-return-41882-m.m.kettenis=alumnus.utwente.nl@sourceware.org
> 
> > Date: Wed, 7 Dec 2005 18:08:07 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> > Cc: gdb-patches@sources.redhat.com
> > 
> > I've checked it in, with some formatting/copyright tweaks
> [...]
> > --- testsuite/gdb.cp/printmethod.cc	17 Jun 2004 18:30:18 -0000	1.2
> > +++ testsuite/gdb.cp/printmethod.cc	7 Dec 2005 23:06:43 -0000
> > @@ -1,6 +1,6 @@
> >  /* This test script is part of GDB, the GNU debugger.
> >  
> > -   Copyright 2002, 2004,
> > +   Copyright 2002, 2004, 2005
> >     Free Software Foundation, Inc.
> 
> According to the copyright notice rules that RMS just published (they
> will probably be available as part of standards.texi or
> maintain.texi), we need to have a "(C)" after the word "Copyright".
> It's true that we don't have this in most of our files, but we might
> as well get started...

Geez, I think we actively removed those in the past at RMS' request.
Well, I suppose it's too much too ask from lawyers too make up their
mind.

Note that we also need to update the FSF address in the copyright
notice.

Mark

Re: [RFC] fix testsuite/gdb.cp/printmethod

[Christophe LYON]

> 
> I agree with your conclusions; this is fine.
> 
> I've checked it in, with some formatting/copyright tweaks, since I
> needed it for the attached followup: the error message previously being
> tested for was lousy, let's improve it.
> 

OK, thanks for the check-in and for your improvement.

Christophe.

Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Eli Zaretskii]

> Date: Wed, 7 Dec 2005 23:42:36 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> On Thu, Dec 08, 2005 at 06:38:03AM +0200, Eli Zaretskii wrote:
> > > Date: Wed, 7 Dec 2005 18:08:07 -0500
> > > From: Daniel Jacobowitz <drow@false.org>
> > > Cc: gdb-patches@sources.redhat.com
> > > 
> > > I've checked it in, with some formatting/copyright tweaks
> > [...]
> > > --- testsuite/gdb.cp/printmethod.cc	17 Jun 2004 18:30:18 -0000	1.2
> > > +++ testsuite/gdb.cp/printmethod.cc	7 Dec 2005 23:06:43 -0000
> > > @@ -1,6 +1,6 @@
> > >  /* This test script is part of GDB, the GNU debugger.
> > >  
> > > -   Copyright 2002, 2004,
> > > +   Copyright 2002, 2004, 2005
> > >     Free Software Foundation, Inc.
> > 
> > According to the copyright notice rules that RMS just published (they
> > will probably be available as part of standards.texi or
> > maintain.texi), we need to have a "(C)" after the word "Copyright".
> > It's true that we don't have this in most of our files, but we might
> > as well get started...
> 
> IMO we really should do them all at once.  The other thing we need to
> do is update the FSF address; I have had this flagged to take care of
> since the FSF moved this spring, but I (obviously) haven't found the
> time...

I've committed the first portion of this monstrous job: all the files
in gdb/ and in gdb/cli/ now have the (c) marker and state the correct
FSF address.  I hope I didn't break anything, but if I did, please
correct as obvious.

I don't imagine someone would actually wish to see the humongous
boring diffs, would they? ;-)

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Daniel Jacobowitz]

On Sun, Dec 18, 2005 at 12:46:48AM +0200, Eli Zaretskii wrote:
> I've committed the first portion of this monstrous job: all the files
> in gdb/ and in gdb/cli/ now have the (c) marker and state the correct
> FSF address.  I hope I didn't break anything, but if I did, please
> correct as obvious.
> 
> I don't imagine someone would actually wish to see the humongous
> boring diffs, would they? ;-)

Eli, thank you for doing this.  I'll run a couple of test cycles here
to confirm that everything's still in order, but I'm sure it will be
:-)

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Mark Kettenis]

> Date: Sun, 18 Dec 2005 00:46:48 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> I've committed the first portion of this monstrous job: all the files
> in gdb/ and in gdb/cli/ now have the (c) marker and state the correct
> FSF address.  I hope I didn't break anything, but if I did, please
> correct as obvious.

Thanks for doing this!

> I don't imagine someone would actually wish to see the humongous
> boring diffs, would they? ;-)

Pleas, no, no, no! ;-).

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Daniel Jacobowitz]

On Sat, Dec 17, 2005 at 06:06:10PM -0500, Daniel Jacobowitz wrote:
> On Sun, Dec 18, 2005 at 12:46:48AM +0200, Eli Zaretskii wrote:
> > I've committed the first portion of this monstrous job: all the files
> > in gdb/ and in gdb/cli/ now have the (c) marker and state the correct
> > FSF address.  I hope I didn't break anything, but if I did, please
> > correct as obvious.
> > 
> > I don't imagine someone would actually wish to see the humongous
> > boring diffs, would they? ;-)
> 
> Eli, thank you for doing this.  I'll run a couple of test cycles here
> to confirm that everything's still in order, but I'm sure it will be
> :-)

The only obvious casualty is default.exp, fixed as attached.

-- 
Daniel Jacobowitz
CodeSourcery, LLC

2005-12-17  Daniel Jacobowitz  <dan@codesourcery.com>

	* gdb.base/default.exp: Update check for "show version".

Index: gdb.base/default.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
retrieving revision 1.18
diff -u -p -r1.18 default.exp
--- gdb.base/default.exp	14 Jul 2005 14:49:23 -0000	1.18
+++ gdb.base/default.exp	17 Dec 2005 23:38:34 -0000
@@ -667,7 +667,7 @@ gdb_test "show values" "" "show values"
 #test show verbose
 gdb_test "show verbose" "Verbose printing of informational messages is o.*|Verbosity is off.*" "show verbose"
 #test show version
-gdb_test "show version" "GNU gdb \[0-9\.\]*(\[^\r\n\]*\[\r\n\])+Copyright \[0-9\]* Free Software Foundation, Inc(\[^\r\n\]*\[\r\n\])+GDB is free software, covered by the GNU General Public License, and you are(\[^\r\n\]*\[\r\n\])+welcome to change it and/or distribute copies of it under certain conditions(\[^\r\n\]*\[\r\n\])+Type \"show copying\" to see the conditions(\[^\r\n\]*\[\r\n\])+There is absolutely no warranty for GDB.  Type \"show warranty\" for details(\[^\r\n\]*\[\r\n\])+This GDB was configured as .*|GDB is free software and you are welcome to distribute copies of it(\[^\r\n\]*\[\r\n\])+ under certain conditions; type \"show copying\" to see the conditions.(\[^\r\n\]*\[\r\n\])+There is absolutely no warranty for GDB; type \"show warranty\" for details.(\[^\r\n\]*\[\r\n\])+GDB.*Copyright \[0-9\]* Free Software Foundation, Inc.*" "show version"
+gdb_test "show version" "GNU gdb \[0-9\.\]*(\[^\r\n\]*\[\r\n\])+Copyright \\(C\\) \[0-9\]* Free Software Foundation, Inc(\[^\r\n\]*\[\r\n\])+GDB is free software, covered by the GNU General Public License, and you are(\[^\r\n\]*\[\r\n\])+welcome to change it and/or distribute copies of it under certain conditions(\[^\r\n\]*\[\r\n\])+Type \"show copying\" to see the conditions(\[^\r\n\]*\[\r\n\])+There is absolutely no warranty for GDB.  Type \"show warranty\" for details(\[^\r\n\]*\[\r\n\])+This GDB was configured as .*|GDB is free software and you are welcome to distribute copies of it(\[^\r\n\]*\[\r\n\])+ under certain conditions; type \"show copying\" to see the conditions.(\[^\r\n\]*\[\r\n\])+There is absolutely no warranty for GDB; type \"show warranty\" for details.(\[^\r\n\]*\[\r\n\])+GDB.*Copyright \\(C\\) \[0-9\]* Free Software Foundation, Inc.*" "show version"
 #test show width
 gdb_test "show width" "Number of characters gdb thinks are in a line is.*" "show width"
 #test show write

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Eli Zaretskii]

> Date: Sun, 18 Dec 2005 00:46:48 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > IMO we really should do them all at once.  The other thing we need to
> > do is update the FSF address; I have had this flagged to take care of
> > since the FSF moved this spring, but I (obviously) haven't found the
> > time...
> 
> I've committed the first portion of this monstrous job: all the files
> in gdb/ and in gdb/cli/ now have the (c) marker and state the correct
> FSF address.  I hope I didn't break anything, but if I did, please
> correct as obvious.

I now did that for gdb/gdbserver, gdbtk/generic, and gdbtk/library.

But I inadvertently hit a snafu in the image subdirectories of
gdbtk/library: due to mismatch of time stamp (it's a long story) and
my failure to use "cvs ci -l", CVS checked in various GIF and PNG
images as well.  The problem is, these are binary files, but they are
not marked with -kb keyword in the repository.  And because I did the
commit from a Windows machine, I'm afraid the files are now corrupted
in the repository.

Could someone please undo my commits to image files in all the
subdirectories of gdbtk/library?  I'd do that myself, but in order to
be able to do that, I need to be a member of the cvsadmin group, which
I apparently am not...

Sorry for the inconvenience.

Re: Update Copyright and FSF address

[Eli Zaretskii]

> Date: Fri, 23 Dec 2005 20:46:06 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > I've committed the first portion of this monstrous job: all the files
> > in gdb/ and in gdb/cli/ now have the (c) marker and state the correct
> > FSF address.  I hope I didn't break anything, but if I did, please
> > correct as obvious.
> 
> I now did that for gdb/gdbserver, gdbtk/generic, and gdbtk/library.

And now also for gdb/mi, gdb/nlm, gdb/tui, and gdb/doc.

This leaves us with gdb/config and gdb/testsuite.

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Daniel Jacobowitz]

On Fri, Dec 23, 2005 at 08:46:06PM +0200, Eli Zaretskii wrote:
> I now did that for gdb/gdbserver, gdbtk/generic, and gdbtk/library.
> 
> But I inadvertently hit a snafu in the image subdirectories of
> gdbtk/library: due to mismatch of time stamp (it's a long story) and
> my failure to use "cvs ci -l", CVS checked in various GIF and PNG
> images as well.  The problem is, these are binary files, but they are
> not marked with -kb keyword in the repository.  And because I did the
> commit from a Windows machine, I'm afraid the files are now corrupted
> in the repository.
> 
> Could someone please undo my commits to image files in all the
> subdirectories of gdbtk/library?  I'd do that myself, but in order to
> be able to do that, I need to be a member of the cvsadmin group, which
> I apparently am not...

You need to be in the cvsadmin group to use "cvs admin" commands, but
it's easy enough to fix this by recommitting from a system with
appropriate line endings (or in this case, it looks like, without the
^Z behavior?).  I've taken care of it, and the images appear
uncorrupted now.

Thanks again!

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Eli Zaretskii]

> Date: Fri, 23 Dec 2005 14:40:42 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> You need to be in the cvsadmin group to use "cvs admin" commands

Well, maybe I should be a member.  Maybe all global maintainers
should.

> but it's easy enough to fix this by recommitting from a system with
> appropriate line endings (or in this case, it looks like, without
> the ^Z behavior?).

Both EOLs and ^Z are actually part of the same issue: the text vs
binary I/O.

> I've taken care of it, and the images appear uncorrupted now.

Thanks.  But the image files are still not marked with -kb.  Can
someone please do that?

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Eli Zaretskii]

> Date: Sat, 24 Dec 2005 10:57:25 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > I've taken care of it, and the images appear uncorrupted now.
> 
> Thanks.  But the image files are still not marked with -kb.  Can
> someone please do that?

I removed the entire GDB tree on my MS-Windows machine and checked it
out again with -kb, so that I will never have to give people trouble
with similar problems again.

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Daniel Jacobowitz]

On Sat, Dec 24, 2005 at 10:57:25AM +0200, Eli Zaretskii wrote:
> > I've taken care of it, and the images appear uncorrupted now.
> 
> Thanks.  But the image files are still not marked with -kb.  Can
> someone please do that?

Done; are you sure you couldn't do that yourself?  I believe admin -kb
doesn't require any privileges (since I don't seem to have any).

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Eli Zaretskii]

> Date: Sat, 24 Dec 2005 11:15:52 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
> On Sat, Dec 24, 2005 at 10:57:25AM +0200, Eli Zaretskii wrote:
> > > I've taken care of it, and the images appear uncorrupted now.
> > 
> > Thanks.  But the image files are still not marked with -kb.  Can
> > someone please do that?
> 
> Done

Thanks.

> are you sure you couldn't do that yourself?  I believe admin -kb
> doesn't require any privileges (since I don't seem to have any).

I didn't even try: I assumed that all admin commands required these
privileges, since "admin -o" wanted them.

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Daniel Jacobowitz]

On Sat, Dec 24, 2005 at 06:31:41PM +0200, Eli Zaretskii wrote:
> > Date: Sat, 24 Dec 2005 11:15:52 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> > 
> > On Sat, Dec 24, 2005 at 10:57:25AM +0200, Eli Zaretskii wrote:
> > > > I've taken care of it, and the images appear uncorrupted now.
> > > 
> > > Thanks.  But the image files are still not marked with -kb.  Can
> > > someone please do that?
> > 
> > Done
> 
> Thanks.
> 
> > are you sure you couldn't do that yourself?  I believe admin -kb
> > doesn't require any privileges (since I don't seem to have any).
> 
> I didn't even try: I assumed that all admin commands required these
> privileges, since "admin -o" wanted them.

Let's see...

         On  unix,  if  there is a group named cvsadmin, only members
         of that group can run cvs admin commands, except for those
         specified using the UserAdminOptions configuration option in
         the CVSROOT/config file.  Options specified using
         UserAdminOptions can be run by any user.  See see node
         `config' in the CVS manual for more on UserAdminOptions.

and:

     When not specified, `UserAdminOptions' defaults to `k'.  In other
     words, it defaults to allowing users outside of the `cvsadmin'
     group to use the `cvs admin' command only to change the default
     keyword expansion mode for files.

There we go; mystery solved.  It covers everything except this :-)

-- 
Daniel Jacobowitz
CodeSourcery, LLC

Re: Update Copyright and FSF address (was: [RFC] fix testsuite/gdb.cp/printmethod)

[Eli Zaretskii]

> Date: Sat, 24 Dec 2005 12:01:59 -0500
> From: Daniel Jacobowitz <drow@false.org>
> 
>          On  unix,  if  there is a group named cvsadmin, only members
>          of that group can run cvs admin commands, except for those
>          specified using the UserAdminOptions configuration option in
>          the CVSROOT/config file.  Options specified using
>          UserAdminOptions can be run by any user.  See see node
>          `config' in the CVS manual for more on UserAdminOptions.
> 
> and:
> 
>      When not specified, `UserAdminOptions' defaults to `k'.  In other
>      words, it defaults to allowing users outside of the `cvsadmin'
>      group to use the `cvs admin' command only to change the default
>      keyword expansion mode for files.

Thanks for taking time to explain this.