From: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
To: gdb-patches@sourceware.org
Subject: Committed: sim/cris: no writes to read-only special registers except specializations
Date: Wed, 07 Dec 2005 15:18:00 -0000 [thread overview]
Message-ID: <200512062246.jB6MkhvQ017581@ignucius.se.axis.com> (raw)
It started as a need to simulate a 32-bit branch expansion that
doesn't affect condition codes. The expansion being "move
[$pc=$pc+offs],$p0" and because of the insn encoding, it seemed
best to handle as invalid writes to read-only special registers
as there'd otherwise be a ambiguity between a [PC+] meaning
(when prefixed) a PC assignment (i.e. jump) or (otherwise) a
constant; field parsing is AFAIK static in CGEN sims and can't
be affected by simulator state. The actual sim changes are to
cris.cpu and sent to binutils@.
Committed.
sim/:
* cris/cpuv10.h, cris/cpuv32.h, cris/cris-desc.c, cris/cris-opc.h,
cris/decodev10.c, cris/decodev10.h, cris/decodev32.c,
cris/decodev32.h, cris/modelv10.c, cris/modelv32.c,
cris/semcrisv10f-switch.c, cris/semcrisv32f-switch.c: Regenerate.
sim/testsuite/:
* sim/cris/asm/movmp8.ms, sim/cris/asm/pcplus.ms: New tests.
* sim/cris/asm/movmp.ms: Do not write to P0, P4 or P8.
* sim/cris/asm/raw13.ms: Write to MOF instead of WZ (P4).
Index: sim/cris/asm/movmp.ms
===================================================================
RCS file: /cvs/src/src/sim/testsuite/sim/cris/asm/movmp.ms,v
retrieving revision 1.1
diff -p -u -r1.1 movmp.ms
--- sim/cris/asm/movmp.ms 21 Nov 2005 04:48:19 -0000 1.1
+++ sim/cris/asm/movmp.ms 6 Dec 2005 22:04:02 -0000
@@ -16,9 +16,14 @@ filler:
.text
; Test that writing to zero-registers is a nop
+ .if 0
+ ; We used to just ignore the writes, but now an error is emitted. We
+ ; keep the test-code but disabled, in case we need to change this again.
move 0xaa,p0
move 0x4433,p4
move 0x55774433,p8
+ .endif
+
moveq -1,r3
setf zcvn
clear.b r3
@@ -36,10 +41,13 @@ filler:
dumpr3
; "Write" using ordinary memory references too.
+ .if 0 ; See ".if 0" above.
move.d filler,r6
move [r6],p0
move [r6],p4
move [r6],p8
+ .endif
+
moveq -1,r3
clear.b r3
dumpr3
@@ -53,9 +61,12 @@ filler:
dumpr3
; And postincremented.
+ .if 0 ; See ".if 0" above.
move [r6+],p0
move [r6+],p4
move [r6+],p8
+ .endif
+
moveq -1,r3
clear.b r3
dumpr3
Index: sim/cris/asm/movmp8.ms
===================================================================
RCS file: sim/cris/asm/movmp8.ms
diff -N sim/cris/asm/movmp8.ms
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ sim/cris/asm/movmp8.ms 6 Dec 2005 22:04:02 -0000
@@ -0,0 +1,33 @@
+# mach: crisv3 crisv8 crisv10
+
+# Make sure that "move [$sp=$sp+16],$p8" works; used in Linux.
+
+ .include "testutils.inc"
+ startnostack
+ move.d x,$sp
+ moveq 0,$r3
+ move [$sp=$sp+16],$p8
+ ; Z not changed.
+ bne 0f
+ nop
+ cmp.d x+16,$sp
+ bne 0f
+ nop
+ move $p8,$r3
+ ; Z not changed.
+ bne 0f
+ ; P8 still 0.
+ test.d $r3
+ bne 0f
+ nop
+ pass
+0:
+ fail
+
+ .data
+x:
+ .dword 0xffffffff
+ .dword 0xffffffff
+ .dword 0xffffffff
+ .dword 0xffffffff
+ .dword 0xffffffff
Index: sim/cris/asm/pcplus.ms
===================================================================
RCS file: sim/cris/asm/pcplus.ms
diff -N sim/cris/asm/pcplus.ms
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ sim/cris/asm/pcplus.ms 6 Dec 2005 22:04:02 -0000
@@ -0,0 +1,46 @@
+# mach: crisv0 crisv3 crisv8 crisv10
+
+; Test that a forward as well as backward 32-bit "branch" expansion
+; works including that the right offset is applied.
+
+ .macro nop32
+ .rept 32
+ nop
+ .endr
+ .endm
+
+ .include "testutils.inc"
+ start
+ jump start1
+ fail
+
+ nop32
+ subq 63,$r10
+9: subq 1,$r10
+ nop32
+ jump 0f
+
+ fail
+0: move [$pc=$pc+1f-6-0b],$p0
+ nop32
+ fail
+
+ .skip 32768,0
+
+ nop32
+ subq 63,$r10
+1:
+ subq 1,$r10
+ nop32
+ test.d $r10
+ bne 7f
+ nop
+ pass
+7:
+ fail
+
+start1:
+ moveq 2,$r10
+0: move [$pc=$pc+9b-6-0b],$p0
+ subq 63,$r10
+ fail
Index: sim/cris/asm/raw13.ms
===================================================================
RCS file: /cvs/src/src/sim/testsuite/sim/cris/asm/raw13.ms,v
retrieving revision 1.1
diff -p -u -r1.1 raw13.ms
--- sim/cris/asm/raw13.ms 21 Nov 2005 04:48:19 -0000 1.1
+++ sim/cris/asm/raw13.ms 6 Dec 2005 22:04:02 -0000
@@ -1,4 +1,4 @@
-; Checking read-after-write: write-WZ-then-read unaffected.
+; Checking read-after-write: write-MOF-then-read unaffected.
#mach: crisv32
#output: Basic clock cycles, total @: 4\n
#output: Memory source stall cycles: 0\n
@@ -17,6 +17,6 @@
.lcomm y,4
move.d x,$r0
move.d y,$r1
- move [$r0],$wz
+ move [$r0],$mof
move [$r1],$srp
break 15
brgds, H-P
reply other threads:[~2005-12-06 22:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512062246.jB6MkhvQ017581@ignucius.se.axis.com \
--to=hans-peter.nilsson@axis.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox