Re: [PATCH][SH] info registers

[Mark Kettenis <mark.kettenis@xs4all.nl>]

> Date: Wed, 16 Nov 2005 15:51:09 +0000
> From: Andrew STUBBS <andrew.stubbs@st.com>
> 
> Hi,
> 
> sh-tdep.c contains quite a lot of code to implement the 'info registers' 
> command (and friends).
> 
> It has a number of issues:
>   - The double and vector registers are only in hex.
>   - Invalid registers are still printed for some types (not that GDB 
> knows which registers are invalid - that's my next patch).
>   - The double registers are incorrectly named dr0..dr7, and the vector 
> registers incorrectly named fv0..fv3. They should be dr0,dr2,dr4... and 
> fv0,fv4,...
> 
> I have discovered that the default code (when the architecture may 
> override) does everything the SH code does right and yet does not do 
> everything it does wrong. Specifically all the above problems are 
> addressed.
> 
> I therefore propose removing all this garbage entirely.

I'm very much in favour of this, but please wait a week or so with
checking this in to give people who actually use gdb for the SH the
opportunity to object.

Mark