From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24245 invoked by alias); 16 Nov 2005 16:19:02 -0000 Received: (qmail 24217 invoked by uid 22791); 16 Nov 2005 16:18:58 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 16 Nov 2005 16:18:58 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id jAGGIuZ7028027; Wed, 16 Nov 2005 17:18:56 +0100 (CET) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id jAGGIuFD014244; Wed, 16 Nov 2005 17:18:56 +0100 (CET) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id jAGGItsB021108; Wed, 16 Nov 2005 17:18:55 +0100 (CET) Date: Wed, 16 Nov 2005 16:54:00 -0000 Message-Id: <200511161618.jAGGItsB021108@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: andrew.stubbs@st.com CC: gdb-patches@sources.redhat.com In-reply-to: <437B556D.2050202@st.com> (message from Andrew STUBBS on Wed, 16 Nov 2005 15:51:09 +0000) Subject: Re: [PATCH][SH] info registers References: <437B556D.2050202@st.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2005-11/txt/msg00235.txt.bz2 > Date: Wed, 16 Nov 2005 15:51:09 +0000 > From: Andrew STUBBS > > Hi, > > sh-tdep.c contains quite a lot of code to implement the 'info registers' > command (and friends). > > It has a number of issues: > - The double and vector registers are only in hex. > - Invalid registers are still printed for some types (not that GDB > knows which registers are invalid - that's my next patch). > - The double registers are incorrectly named dr0..dr7, and the vector > registers incorrectly named fv0..fv3. They should be dr0,dr2,dr4... and > fv0,fv4,... > > I have discovered that the default code (when the architecture may > override) does everything the SH code does right and yet does not do > everything it does wrong. Specifically all the above problems are > addressed. > > I therefore propose removing all this garbage entirely. I'm very much in favour of this, but please wait a week or so with checking this in to give people who actually use gdb for the SH the opportunity to object. Mark