From: Daniel Jacobowitz <drow@false.org>
To: Stephane Carrez <stcarrez@nerim.fr>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: TUI testsuite
Date: Sun, 13 Nov 2005 18:12:00 -0000 [thread overview]
Message-ID: <20051113180236.GB2635@nevyn.them.org> (raw)
In-Reply-To: <43762F9C.8020604@nerim.fr>
On Sat, Nov 12, 2005 at 07:08:28PM +0100, Stephane Carrez wrote:
> Hi!
>
> A long long time ago, I submitted a TUI testsuite for the validation
> of the gdb TUI:
I like it! But, it needs some work.
Some minor cosmetic things (I haven't looked through it for more,
these just popped out at me):
- TUITERM is unused, whew, I was wondering why you needed xterm.
- Semicolons at the ends of lines aren't needed in TCL
- Please don't add the @prep.ai.mit.edu address to new files;
you can just delete that paragraph.
- Please don't use gdb_suppress_entire_file any more. Just
use "untested <DESCRIPTION>" and return -1.
One substantive problem: to add a new directory to the testsuite you
also need to update a couple files in testsuite/. Search for one of
the other testsuite directory names to find where. Otherwise gdb.tui
won't be created in the object directory.
Three tests failed on my x86-64 system:
FAIL: gdb.tui/tui-break.exp: TUI, display of asm window (timeout)
FAIL: gdb.tui/tui-break.exp: TUI, stepi of asm window, pass 0, (timeout)
FAIL: gdb.tui/tui-single-key.exp: TUI, SingleKey 'u', (timeout)
The output in gdb.log is incredibly hard to read, so I am not sure why.
Don't worry about that for now; when it goes in, I'll fix them.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-11-13 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-13 18:02 Stephane Carrez
2005-11-13 18:12 ` Daniel Jacobowitz [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-10 18:48 Stephane Carrez
2003-08-18 17:30 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051113180236.GB2635@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=stcarrez@nerim.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox