From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17860 invoked by alias); 13 Nov 2005 18:02:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17844 invoked by uid 22791); 13 Nov 2005 18:02:39 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 13 Nov 2005 18:02:39 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EbMBY-0000pc-92; Sun, 13 Nov 2005 13:02:36 -0500 Date: Sun, 13 Nov 2005 18:12:00 -0000 From: Daniel Jacobowitz To: Stephane Carrez Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: TUI testsuite Message-ID: <20051113180236.GB2635@nevyn.them.org> Mail-Followup-To: Stephane Carrez , gdb-patches@sources.redhat.com References: <43762F9C.8020604@nerim.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43762F9C.8020604@nerim.fr> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-11/txt/msg00164.txt.bz2 On Sat, Nov 12, 2005 at 07:08:28PM +0100, Stephane Carrez wrote: > Hi! > > A long long time ago, I submitted a TUI testsuite for the validation > of the gdb TUI: I like it! But, it needs some work. Some minor cosmetic things (I haven't looked through it for more, these just popped out at me): - TUITERM is unused, whew, I was wondering why you needed xterm. - Semicolons at the ends of lines aren't needed in TCL - Please don't add the @prep.ai.mit.edu address to new files; you can just delete that paragraph. - Please don't use gdb_suppress_entire_file any more. Just use "untested " and return -1. One substantive problem: to add a new directory to the testsuite you also need to update a couple files in testsuite/. Search for one of the other testsuite directory names to find where. Otherwise gdb.tui won't be created in the object directory. Three tests failed on my x86-64 system: FAIL: gdb.tui/tui-break.exp: TUI, display of asm window (timeout) FAIL: gdb.tui/tui-break.exp: TUI, stepi of asm window, pass 0, (timeout) FAIL: gdb.tui/tui-single-key.exp: TUI, SingleKey 'u', (timeout) The output in gdb.log is incredibly hard to read, so I am not sure why. Don't worry about that for now; when it goes in, I'll fix them. -- Daniel Jacobowitz CodeSourcery, LLC