From: Daniel Jacobowitz <drow@false.org>
To: Paul Gilliam <pgilliam@us.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] deal with vector return value for ppc68
Date: Wed, 02 Nov 2005 22:42:00 -0000 [thread overview]
Message-ID: <20051102204359.GA6755@nevyn.them.org> (raw)
In-Reply-To: <200510241606.10304.pgilliam@us.ibm.com>
On Mon, Oct 24, 2005 at 04:06:10PM -0700, Paul Gilliam wrote:
> 2005-10-24 Paul Gilliam <pgilliam@us.ibm.com
>
> * ppc-sysv-tdep.c (ppc64_sysv_abi_return_value): Copy code from
> ppc_sysv_abi_return_value() to handle a vector return value.
Kevin's approved this but before you check it in please fix the
formatting.
> + /* Array type has more than one use. */
Two spaces after periods.
> + /* A VMX vector is returned in v2. */
Ditto.
> + if (readbuf)
> + {
> + regcache_cooked_read (regcache, tdep->ppc_vr0_regnum+2, readbuf);
> + }
> + if (writebuf)
> + {
> + regcache_cooked_write(regcache, tdep->ppc_vr0_regnum+2, writebuf);
> + }
Useless braces; spaces before parentheses.
Thanks.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-11-02 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-24 23:47 Paul Gilliam
2005-11-02 21:59 ` Kevin Buettner
2005-11-07 23:33 ` Paul Gilliam
2005-11-08 0:10 ` Paul Gilliam
2005-11-08 17:46 ` Kevin Buettner
2005-11-09 6:56 ` Joel Brobecker
2005-11-09 7:24 ` Kevin Buettner
2005-11-15 4:10 ` [COMMIT (6.4)] " Paul Gilliam
2005-11-15 4:40 ` Paul Gilliam
2005-11-02 22:42 ` Daniel Jacobowitz [this message]
2005-11-03 1:31 ` [PATCH] " Mark Kettenis
2005-11-07 21:42 ` [COMMIT] " Paul Gilliam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051102204359.GA6755@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=pgilliam@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox