From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28689 invoked by alias); 2 Nov 2005 20:44:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28283 invoked by uid 22791); 2 Nov 2005 20:44:03 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 02 Nov 2005 20:44:02 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1EXPSi-0001mE-1n; Wed, 02 Nov 2005 15:44:00 -0500 Date: Wed, 02 Nov 2005 22:42:00 -0000 From: Daniel Jacobowitz To: Paul Gilliam Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] deal with vector return value for ppc68 Message-ID: <20051102204359.GA6755@nevyn.them.org> Mail-Followup-To: Paul Gilliam , gdb-patches@sources.redhat.com References: <200510241606.10304.pgilliam@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200510241606.10304.pgilliam@us.ibm.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-11/txt/msg00044.txt.bz2 On Mon, Oct 24, 2005 at 04:06:10PM -0700, Paul Gilliam wrote: > 2005-10-24 Paul Gilliam > * ppc-sysv-tdep.c (ppc64_sysv_abi_return_value): Copy code from > ppc_sysv_abi_return_value() to handle a vector return value. Kevin's approved this but before you check it in please fix the formatting. > + /* Array type has more than one use. */ Two spaces after periods. > + /* A VMX vector is returned in v2. */ Ditto. > + if (readbuf) > + { > + regcache_cooked_read (regcache, tdep->ppc_vr0_regnum+2, readbuf); > + } > + if (writebuf) > + { > + regcache_cooked_write(regcache, tdep->ppc_vr0_regnum+2, writebuf); > + } Useless braces; spaces before parentheses. Thanks. -- Daniel Jacobowitz CodeSourcery, LLC