From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pgilliam@us.ibm.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] allow gdb to access altivec registers
Date: Mon, 17 Oct 2005 21:05:00 -0000 [thread overview]
Message-ID: <200510172105.j9HL5BZ1015357@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <200510171332.13857.pgilliam@us.ibm.com> (message from Paul Gilliam on Mon, 17 Oct 2005 13:32:13 -0700)
> From: Paul Gilliam <pgilliam@us.ibm.com>
> Date: Mon, 17 Oct 2005 13:32:13 -0700
>
> In rs6000-tdep.c (rs6000_gdbarch_init), bfd_mach_ppc64 is assumed to NOT have
> altivec registers.
>
> This patch makes it assume that it does. This works for machines with the
> IBM PowerPC 970 chip, an IBM JS-20 or Apple G5 for example.
>
> If the bfd_mach_ppc64 should happen to NOT have an altivec unit, the ptrace
> to get the vector registers will fail the first time it's called and it will
> never be called again.
You're assuming Linux here, but this is generic POWER/PowerPC code.
Unless there are no 64-bit POWER/PowerPC implementations without
AltiVec unit, this patch is wrong.
Mark
next prev parent reply other threads:[~2005-10-17 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-17 20:31 Paul Gilliam
2005-10-17 21:05 ` Mark Kettenis [this message]
2005-10-17 21:06 ` Daniel Jacobowitz
2005-10-21 22:46 ` Paul Gilliam
2005-10-27 9:46 ` Kevin Buettner
2005-10-31 22:51 ` [PATCH] allow gdb to access altivec registers - OK to commit? Paul Gilliam
2005-11-01 0:27 ` Andreas Schwab
2005-11-02 20:44 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510172105.j9HL5BZ1015357@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=pgilliam@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox