From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31454 invoked by alias); 17 Oct 2005 21:05:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31444 invoked by uid 22791); 17 Oct 2005 21:05:14 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 17 Oct 2005 21:05:14 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.4/8.13.4) with ESMTP id j9HL5B8I002621; Mon, 17 Oct 2005 23:05:12 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j9HL5BI5002284; Mon, 17 Oct 2005 23:05:11 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j9HL5BZ1015357; Mon, 17 Oct 2005 23:05:11 +0200 (CEST) Date: Mon, 17 Oct 2005 21:05:00 -0000 Message-Id: <200510172105.j9HL5BZ1015357@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: pgilliam@us.ibm.com CC: gdb-patches@sources.redhat.com In-reply-to: <200510171332.13857.pgilliam@us.ibm.com> (message from Paul Gilliam on Mon, 17 Oct 2005 13:32:13 -0700) Subject: Re: [PATCH] allow gdb to access altivec registers References: <200510171332.13857.pgilliam@us.ibm.com> X-SW-Source: 2005-10/txt/msg00143.txt.bz2 > From: Paul Gilliam > Date: Mon, 17 Oct 2005 13:32:13 -0700 > > In rs6000-tdep.c (rs6000_gdbarch_init), bfd_mach_ppc64 is assumed to NOT have > altivec registers. > > This patch makes it assume that it does. This works for machines with the > IBM PowerPC 970 chip, an IBM JS-20 or Apple G5 for example. > > If the bfd_mach_ppc64 should happen to NOT have an altivec unit, the ptrace > to get the vector registers will fail the first time it's called and it will > never be called again. You're assuming Linux here, but this is generic POWER/PowerPC code. Unless there are no 64-bit POWER/PowerPC implementations without AltiVec unit, this patch is wrong. Mark