From: Daniel Jacobowitz <drow@false.org>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Broken cast in linux-thread-db
Date: Wed, 12 Oct 2005 14:41:00 -0000 [thread overview]
Message-ID: <20051012144130.GA21870@nevyn.them.org> (raw)
In-Reply-To: <jey84yst3c.fsf@sykes.suse.de>
On Wed, Oct 12, 2005 at 04:33:27PM +0200, Andreas Schwab wrote:
> Daniel Jacobowitz <drow@false.org> writes:
>
> > I think the current behavior is actually more correct despite any
> > warning.
>
> GCC _always_ sign extends, which is definitely wrong here.
Well presumably it honors POINTERS_EXTEND_UNSIGNED.
> > Were you fixing an observed problem?
>
> If notify.u.bptaddr has the high bit set it will be sign extended, but the
> breakpoint address when the thread event breakpoint is hit will be zero
> extended, so they don't match and the breakpoint is not recognized.
Then this will break thread debugging on MIPS, where the breakpoint
address will be sign extended. We'll only be in linux-thread-db.c if
we have enough symbols to load shared libraries; maybe
bfd_get_sign_extend_vma (exec_bfd) and assert that exec_bfd is
provided?
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-10-12 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-12 14:13 Andreas Schwab
2005-10-12 14:24 ` Daniel Jacobowitz
2005-10-12 14:33 ` Andreas Schwab
2005-10-12 14:41 ` Daniel Jacobowitz [this message]
2005-10-12 15:59 ` Andreas Schwab
2005-10-12 17:43 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051012144130.GA21870@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox