Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Andreas Schwab <schwab@suse.de>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Broken cast in linux-thread-db
Date: Wed, 12 Oct 2005 14:24:00 -0000	[thread overview]
Message-ID: <20051012142427.GA21308@nevyn.them.org> (raw)
In-Reply-To: <jebr1uu8lk.fsf@sykes.suse.de>

On Wed, Oct 12, 2005 at 04:13:11PM +0200, Andreas Schwab wrote:
> Casting a pointer to CORE_ADDR results in implementation defined behaviour
> when the latter is wider than a pointer.  The implementation's behaviour
> might be to sign extend which is not what we want here.  Tested on
> i386-suse-linux with --enable-64-bit-bfd.

This will silence the warning, but AFAICS not fix anything.  Now you're
casting it to something explicitly unsigned, but the same size as a
pointer; but GDB tries to use the target's sign extension conventions,
and a CORE_ADDR ought to be properly sign extended on MIPS.

I think the current behavior is actually more correct despite any
warning.  Were you fixing an observed problem?

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-10-12 14:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-12 14:13 Andreas Schwab
2005-10-12 14:24 ` Daniel Jacobowitz [this message]
2005-10-12 14:33   ` Andreas Schwab
2005-10-12 14:41     ` Daniel Jacobowitz
2005-10-12 15:59       ` Andreas Schwab
2005-10-12 17:43         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051012142427.GA21308@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox