Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Alan Modra <amodra@bigpond.net.au>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fix powerpc64-linux inferior function calls
Date: Sun, 02 Oct 2005 23:48:00 -0000	[thread overview]
Message-ID: <20051002234834.GA4773@nevyn.them.org> (raw)
In-Reply-To: <20051002232228.GB26007@bubble.grove.modra.org>

On Mon, Oct 03, 2005 at 08:52:28AM +0930, Alan Modra wrote:
> >  I'm thinking of
> > the patch I posted here:
> >     http://sourceware.org/ml/gdb-patches/2005-06/msg00220.html           
> > and pinged a few weeks ago.
> 
> Which I see you do in this patch too.  I didn't know about your patch
> when I wrote mine..  The order of processing doesn't matter at all.
> It just fell out that way in my patch.  Incidentally, why did you
> need to fudge the synthetic syms?
> 
> +	  /* Synthetic symbols are not, strictly speaking, either local
> +	     or global.  But we can treat them as global symbols, since
> +	     they are effectively dynamic symbols.  */
> +	  synth_symbol_table[i]->flags |= BSF_GLOBAL;
> 
> Seems like this should be done in bfd if necessary.

I don't remember precisely... ah, here it is.  See elf_symtab_read.

          if (sym->flags & BSF_FILE)
...
          else if (sym->flags & BSF_SECTION_SYM)
...
          else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK))

They won't be recorded as symbols if they have none of these bits set.
Do you want to change BFD to always create them as BSF_GLOBAL?

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-10-02 23:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-28  7:34 Alan Modra
2005-10-02 22:31 ` Daniel Jacobowitz
2005-10-02 23:22   ` Alan Modra
2005-10-02 23:48     ` Daniel Jacobowitz [this message]
2005-10-03  0:35       ` Alan Modra
2005-10-03  1:04         ` Daniel Jacobowitz
2005-10-03  3:32           ` Alan Modra
2005-10-03  4:40             ` Daniel Jacobowitz
2005-10-03  8:20               ` Alan Modra
2006-03-03 14:04                 ` David Lecomber
2006-03-03 14:11                   ` David Lecomber
2006-03-30  9:53                   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051002234834.GA4773@nevyn.them.org \
    --to=drow@false.org \
    --cc=amodra@bigpond.net.au \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox