From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7956 invoked by alias); 2 Oct 2005 23:48:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7942 invoked by uid 22791); 2 Oct 2005 23:48:37 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 02 Oct 2005 23:48:37 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1EMDZK-0001Fz-Vo; Sun, 02 Oct 2005 19:48:35 -0400 Date: Sun, 02 Oct 2005 23:48:00 -0000 From: Daniel Jacobowitz To: Alan Modra Cc: gdb-patches@sources.redhat.com Subject: Re: Fix powerpc64-linux inferior function calls Message-ID: <20051002234834.GA4773@nevyn.them.org> Mail-Followup-To: Alan Modra , gdb-patches@sources.redhat.com References: <20050928073345.GK29044@bubble.grove.modra.org> <20051002223118.GC32728@nevyn.them.org> <20051002232228.GB26007@bubble.grove.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051002232228.GB26007@bubble.grove.modra.org> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-10/txt/msg00010.txt.bz2 On Mon, Oct 03, 2005 at 08:52:28AM +0930, Alan Modra wrote: > > I'm thinking of > > the patch I posted here: > > http://sourceware.org/ml/gdb-patches/2005-06/msg00220.html > > and pinged a few weeks ago. > > Which I see you do in this patch too. I didn't know about your patch > when I wrote mine.. The order of processing doesn't matter at all. > It just fell out that way in my patch. Incidentally, why did you > need to fudge the synthetic syms? > > + /* Synthetic symbols are not, strictly speaking, either local > + or global. But we can treat them as global symbols, since > + they are effectively dynamic symbols. */ > + synth_symbol_table[i]->flags |= BSF_GLOBAL; > > Seems like this should be done in bfd if necessary. I don't remember precisely... ah, here it is. See elf_symtab_read. if (sym->flags & BSF_FILE) ... else if (sym->flags & BSF_SECTION_SYM) ... else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK)) They won't be recorded as symbols if they have none of these bits set. Do you want to change BFD to always create them as BSF_GLOBAL? -- Daniel Jacobowitz CodeSourcery, LLC