From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@redhat.com
Cc: scallanan@apple.com, gdb-patches@sources.redhat.com
Subject: Re: terminate-on-error patch
Date: Mon, 22 Aug 2005 19:56:00 -0000 [thread overview]
Message-ID: <200508221938.j7MJc5we013300@elgar.sibelius.xs4all.nl> (raw)
In-Reply-To: <430A19FC.8080400@redhat.com> (message from Michael Snyder on Mon, 22 Aug 2005 11:31:24 -0700)
> Date: Mon, 22 Aug 2005 11:31:24 -0700
> From: Michael Snyder <msnyder@redhat.com>
>
> Sean,
>
> I think this is a great idea, and it seems like a good implementation.
> Kudos on including both documentation and tests!
>
> Anybody see any objection to this going in?
Apart from a line that seems to be too long:
> > Index: gdb/wrapper.h
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/wrapper.h,v
> > retrieving revision 1.14
> > diff -c -r1.14 wrapper.h
> > *** gdb/wrapper.h 16 Feb 2005 13:21:48 -0000 1.14
> > --- gdb/wrapper.h 11 Aug 2005 19:42:17 -0000
> > ***************
> > *** 50,53 ****
> > --- 50,56 ----
> >
> > extern int gdb_parse_and_eval_type (char *, int, struct type **);
> >
> > + /* Longjmp-safe wrapper for "execute_command". */
> > + extern struct gdb_exception safe_execute_command (struct ui_out *,
> > char *, int);
this looks fine to me.
Mark
next prev parent reply other threads:[~2005-08-22 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-11 22:23 Sean Callanan
2005-08-22 18:33 ` Michael Snyder
2005-08-22 19:56 ` Mark Kettenis [this message]
2005-08-30 2:37 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200508221938.j7MJc5we013300@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
--cc=scallanan@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox