From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28532 invoked by alias); 22 Aug 2005 19:38:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28474 invoked by uid 22791); 22 Aug 2005 19:38:31 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 22 Aug 2005 19:38:31 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j7MJcASn023487; Mon, 22 Aug 2005 21:38:10 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j7MJcAxB024693; Mon, 22 Aug 2005 21:38:10 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j7MJc5we013300; Mon, 22 Aug 2005 21:38:05 +0200 (CEST) Date: Mon, 22 Aug 2005 19:56:00 -0000 Message-Id: <200508221938.j7MJc5we013300@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: msnyder@redhat.com CC: scallanan@apple.com, gdb-patches@sources.redhat.com In-reply-to: <430A19FC.8080400@redhat.com> (message from Michael Snyder on Mon, 22 Aug 2005 11:31:24 -0700) Subject: Re: terminate-on-error patch References: <430A19FC.8080400@redhat.com> X-SW-Source: 2005-08/txt/msg00233.txt.bz2 > Date: Mon, 22 Aug 2005 11:31:24 -0700 > From: Michael Snyder > > Sean, > > I think this is a great idea, and it seems like a good implementation. > Kudos on including both documentation and tests! > > Anybody see any objection to this going in? Apart from a line that seems to be too long: > > Index: gdb/wrapper.h > > =================================================================== > > RCS file: /cvs/src/src/gdb/wrapper.h,v > > retrieving revision 1.14 > > diff -c -r1.14 wrapper.h > > *** gdb/wrapper.h 16 Feb 2005 13:21:48 -0000 1.14 > > --- gdb/wrapper.h 11 Aug 2005 19:42:17 -0000 > > *************** > > *** 50,53 **** > > --- 50,56 ---- > > > > extern int gdb_parse_and_eval_type (char *, int, struct type **); > > > > + /* Longjmp-safe wrapper for "execute_command". */ > > + extern struct gdb_exception safe_execute_command (struct ui_out *, > > char *, int); this looks fine to me. Mark