From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: Re: mi_gdb_test MESSAGE parameter
Date: Tue, 02 Aug 2005 03:06:00 -0000 [thread overview]
Message-ID: <20050802030653.GB29761@nevyn.them.org> (raw)
In-Reply-To: <20050801183145.GA27427@white>
On Mon, Aug 01, 2005 at 02:31:45PM -0400, Bob Rossi wrote:
> Hi,
>
> Here is a pre-patch to my previous testsuite patch. I think it makes a
> lot of sense to make the MESSAGE parameter to mi_gdb_test necessary.
> There was only 1 testcase not using the MESSAGE parameter, and it was
> using it 1/2 the time.
I agree. This is basically OK. Please fix two little things for me
and check it in.
> 2005-08-1 Bob Rossi <bob@brasko.net>
2005-08-01
> -mi_gdb_test "400-break-insert foo" "400\\^done,bkpt=\{number=\"2\",type=\"breakpoint\",disp=\"keep\",enabled=\"y\",addr=\"$hex\",func=\"foo\",file=\".*mi-syn-frame.c\",line=\"$decimal\",times=\"0\"\}"
> +mi_gdb_test "400-break-insert foo" \
> +"400\\^done,bkpt=\{number=\"2\",type=\"breakpoint\",disp=\"keep\",enabled=\"y\",addr=\"$hex\",func=\"foo\",file=\".*mi-syn-frame.c\",line=\"$decimal\",times=\"0\"\}" \
> +"insert breakpoint foo"
Please indend continued lines. I'm not sure what the standard
indentation is in the testsuite but two spaces, four spaces, or a tab
is probably a good bet. I see all three in use.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-08-02 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-01 18:31 Bob Rossi
2005-08-02 3:06 ` Daniel Jacobowitz [this message]
2005-08-02 14:21 ` Bob Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050802030653.GB29761@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox