From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20001 invoked by alias); 2 Aug 2005 03:06:57 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 19989 invoked by uid 22791); 2 Aug 2005 03:06:54 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Tue, 02 Aug 2005 03:06:54 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1Dzn7F-0004Ea-8y for gdb-patches@sources.redhat.com; Mon, 01 Aug 2005 23:06:53 -0400 Date: Tue, 02 Aug 2005 03:06:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: mi_gdb_test MESSAGE parameter Message-ID: <20050802030653.GB29761@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20050801183145.GA27427@white> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050801183145.GA27427@white> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-08/txt/msg00036.txt.bz2 On Mon, Aug 01, 2005 at 02:31:45PM -0400, Bob Rossi wrote: > Hi, > > Here is a pre-patch to my previous testsuite patch. I think it makes a > lot of sense to make the MESSAGE parameter to mi_gdb_test necessary. > There was only 1 testcase not using the MESSAGE parameter, and it was > using it 1/2 the time. I agree. This is basically OK. Please fix two little things for me and check it in. > 2005-08-1 Bob Rossi 2005-08-01 > -mi_gdb_test "400-break-insert foo" "400\\^done,bkpt=\{number=\"2\",type=\"breakpoint\",disp=\"keep\",enabled=\"y\",addr=\"$hex\",func=\"foo\",file=\".*mi-syn-frame.c\",line=\"$decimal\",times=\"0\"\}" > +mi_gdb_test "400-break-insert foo" \ > +"400\\^done,bkpt=\{number=\"2\",type=\"breakpoint\",disp=\"keep\",enabled=\"y\",addr=\"$hex\",func=\"foo\",file=\".*mi-syn-frame.c\",line=\"$decimal\",times=\"0\"\}" \ > +"insert breakpoint foo" Please indend continued lines. I'm not sure what the standard indentation is in the testsuite but two spaces, four spaces, or a tab is probably a good bet. I see all three in use. -- Daniel Jacobowitz CodeSourcery, LLC