Re: [RFA] New testcase to evaluate Fortran substring expression

[Daniel Jacobowitz <drow@false.org>]

On Fri, Jul 15, 2005 at 06:25:02PM +0800, Wu Zhou wrote:
> Daniel,
> 
> I made some modification to the original patch.  The changes include:       
> 
> - Don't include "arglist :  arglist, subrange".  Because I don't figure   
> out how to evaluate multi-dimension array section yet.
> 
> - Only add a new operator: OP_F90_RANGE and get the range type wrapped by
> this operator.
> 
> - Change the name of new testcase from substring to subarray.  Because    
> g77 will handle string variable as character array instead. (gfortran did
> this too)  Added four tests for substring evaluation in gdb.fortran/exprs.exp, 
> the reason is that g77 and gfortran still treat string constant as string.
> 
> Please help review this too.  Thanks a lot!

This is looks very good!  Two comments for you:

  - The magic (and undocumented) constants are not a good idea.  Rather
    than being clever with abs(), how about using an enum saying what
    sort of range it is?

  - You have a bunch of lines which are too long in eval.c; could you
    fix that, please?


-- 
Daniel Jacobowitz
CodeSourcery, LLC