From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12662 invoked by alias); 1 Aug 2005 02:12:59 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12654 invoked by uid 22791); 1 Aug 2005 02:12:55 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 01 Aug 2005 02:12:55 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1DzPnR-0004hY-Sc; Sun, 31 Jul 2005 22:12:53 -0400 Date: Mon, 01 Aug 2005 02:12:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] New testcase to evaluate Fortran substring expression Message-ID: <20050801021253.GH30901@nevyn.them.org> Mail-Followup-To: Wu Zhou , gdb-patches@sources.redhat.com References: <20050703185733.GI13811@nevyn.them.org> <20050714234612.GA21620@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-08/txt/msg00005.txt.bz2 On Fri, Jul 15, 2005 at 06:25:02PM +0800, Wu Zhou wrote: > Daniel, > > I made some modification to the original patch. The changes include: > > - Don't include "arglist : arglist, subrange". Because I don't figure > out how to evaluate multi-dimension array section yet. > > - Only add a new operator: OP_F90_RANGE and get the range type wrapped by > this operator. > > - Change the name of new testcase from substring to subarray. Because > g77 will handle string variable as character array instead. (gfortran did > this too) Added four tests for substring evaluation in gdb.fortran/exprs.exp, > the reason is that g77 and gfortran still treat string constant as string. > > Please help review this too. Thanks a lot! This is looks very good! Two comments for you: - The magic (and undocumented) constants are not a good idea. Rather than being clever with abs(), how about using an enum saying what sort of range it is? - You have a bunch of lines which are too long in eval.c; could you fix that, please? -- Daniel Jacobowitz CodeSourcery, LLC