Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Follow forks on HP-UX 11.xx
Date: Wed, 20 Jul 2005 13:35:00 -0000	[thread overview]
Message-ID: <20050720133457.GA29260@nevyn.them.org> (raw)
In-Reply-To: <200507201325.j6KDPZvi030460@elgar.sibelius.xs4all.nl>

On Wed, Jul 20, 2005 at 03:25:35PM +0200, Mark Kettenis wrote:
> This patch adds back the feature that was lost when I revised the
> HP-UX native code.  There are still a few rough edges, but it works
> well enough to be useful.  So I committed this.  I'll try to polish up
> the testsuite and fix the bugs that uncovers.

Cool.  Two comments:

> +  if (follow_child)
> +    {
> +      inferior_ptid = ptid_build (fpid, flwpid, 0);
> +      detach_breakpoints (pid);
> +
> +      target_terminal_ours ();
> +      fprintf_unfiltered (gdb_stdlog, _("\
> +Attaching after fork to child process %ld.\n"), (long)fpid);
> +    }
> +  else
> +    {
> +      inferior_ptid = ptid_build (pid, lwpid, 0);
> +      detach_breakpoints (fpid);
> +
> +      target_terminal_ours ();
> +      fprintf_unfiltered (gdb_stdlog, _("\
> +Detaching after fork from child process %ld.\n"), (long)fpid);
> +    }

For GNU/Linux I recently moved these printouts to debug only.  No one
really seems to want to see them unless they already have a catchpoint.

And, the testcases for following vfork all rely on following exec.  I
haven't enabled them, or that feature, because the current user
interface for following exec is so awful - it silently changes which
binary you're debugging, messes up configured breakpoints, etc etc.

I don't recall if you have GNU/Linux systems to test on.  If not, let
me know if you have testsuite changes you want to check with the
GNU/Linux implementation of fork following.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


       reply	other threads:[~2005-07-20 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200507201325.j6KDPZvi030460@elgar.sibelius.xs4all.nl>
2005-07-20 13:35 ` Daniel Jacobowitz [this message]
2005-07-20 16:29   ` Mark Kettenis
2005-07-20 16:35     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050720133457.GA29260@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mark.kettenis@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox