From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4483 invoked by alias); 20 Jul 2005 13:35:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4447 invoked by uid 22791); 20 Jul 2005 13:34:59 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Wed, 20 Jul 2005 13:34:59 +0000 Received: from drow by nevyn.them.org with local (Exim 4.52) id 1DvEiv-0007eT-Re; Wed, 20 Jul 2005 09:34:57 -0400 Date: Wed, 20 Jul 2005 13:35:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [commit] Follow forks on HP-UX 11.xx Message-ID: <20050720133457.GA29260@nevyn.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <200507201325.j6KDPZvi030460@elgar.sibelius.xs4all.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200507201325.j6KDPZvi030460@elgar.sibelius.xs4all.nl> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00165.txt.bz2 On Wed, Jul 20, 2005 at 03:25:35PM +0200, Mark Kettenis wrote: > This patch adds back the feature that was lost when I revised the > HP-UX native code. There are still a few rough edges, but it works > well enough to be useful. So I committed this. I'll try to polish up > the testsuite and fix the bugs that uncovers. Cool. Two comments: > + if (follow_child) > + { > + inferior_ptid = ptid_build (fpid, flwpid, 0); > + detach_breakpoints (pid); > + > + target_terminal_ours (); > + fprintf_unfiltered (gdb_stdlog, _("\ > +Attaching after fork to child process %ld.\n"), (long)fpid); > + } > + else > + { > + inferior_ptid = ptid_build (pid, lwpid, 0); > + detach_breakpoints (fpid); > + > + target_terminal_ours (); > + fprintf_unfiltered (gdb_stdlog, _("\ > +Detaching after fork from child process %ld.\n"), (long)fpid); > + } For GNU/Linux I recently moved these printouts to debug only. No one really seems to want to see them unless they already have a catchpoint. And, the testcases for following vfork all rely on following exec. I haven't enabled them, or that feature, because the current user interface for following exec is so awful - it silently changes which binary you're debugging, messes up configured breakpoints, etc etc. I don't recall if you have GNU/Linux systems to test on. If not, let me know if you have testsuite changes you want to check with the GNU/Linux implementation of fork following. -- Daniel Jacobowitz CodeSourcery, LLC