From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gdb-patches@sourceware.org
Subject: [commit] Use xsnprint for xxx_pid_to_str()
Date: Mon, 18 Jul 2005 21:01:00 -0000 [thread overview]
Message-ID: <200507182101.j6IL1CjP015639@elgar.sibelius.xs4all.nl> (raw)
Small simplification now that we have xsnprintf. Please do something
similar to your favourite code if it doesn't use this idiom yet.
Committed,
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* target.c (normal_pid_to_str): Use xsnprintf instead of snprintf.
* bsd-uthread.c (bsd_uthread_pid_to_str): Likewise.
* inf-ttrace.c (inf_ttrace_pid_to_str): Likewise.
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.109
diff -u -p -r1.109 target.c
--- target.c 28 May 2005 16:44:29 -0000 1.109
+++ target.c 18 Jul 2005 20:51:40 -0000
@@ -1793,10 +1793,8 @@ char *
normal_pid_to_str (ptid_t ptid)
{
static char buf[32];
- int size;
- size = snprintf (buf, sizeof buf, "process %d", ptid_get_pid (ptid));
- gdb_assert (size < sizeof buf);
+ xsnprintf (buf, sizeof buf, "process %d", ptid_get_pid (ptid));
return buf;
}
Index: bsd-uthread.c
===================================================================
RCS file: /cvs/src/src/gdb/bsd-uthread.c,v
retrieving revision 1.5
diff -u -p -r1.5 bsd-uthread.c
--- bsd-uthread.c 4 Jul 2005 13:38:55 -0000 1.5
+++ bsd-uthread.c 18 Jul 2005 20:51:40 -0000
@@ -469,11 +469,9 @@ bsd_uthread_pid_to_str (ptid_t ptid)
if (ptid_get_tid (ptid) != 0)
{
static char buf[64];
- int size;
- size = snprintf (buf, sizeof buf, "process %d, thread 0x%lx",
- ptid_get_pid (ptid), ptid_get_tid (ptid));
- gdb_assert (size < sizeof buf);
+ xsnprintf (buf, sizeof buf, "process %d, thread 0x%lx",
+ ptid_get_pid (ptid), ptid_get_tid (ptid));
return buf;
}
Index: inf-ttrace.c
===================================================================
RCS file: /cvs/src/src/gdb/inf-ttrace.c,v
retrieving revision 1.10
diff -u -p -r1.10 inf-ttrace.c
--- inf-ttrace.c 21 Jun 2005 11:58:39 -0000 1.10
+++ inf-ttrace.c 18 Jul 2005 20:51:40 -0000
@@ -909,11 +909,9 @@ inf_ttrace_pid_to_str (ptid_t ptid)
pid_t pid = ptid_get_pid (ptid);
lwpid_t lwpid = ptid_get_lwp (ptid);
static char buf[128];
- int size;
- size = snprintf (buf, sizeof buf, "process %ld, lwp %ld",
- (long)pid, (long)lwpid);
- gdb_assert (size < sizeof buf);
+ xsnprintf (buf, sizeof buf, "process %ld, lwp %ld",
+ (long)pid, (long)lwpid);
return buf;
}
next reply other threads:[~2005-07-18 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-18 21:01 Mark Kettenis [this message]
2005-07-19 13:03 ` Wu Zhou
2005-07-19 17:20 ` Mark Kettenis
2005-07-20 3:06 ` Wu Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507182101.j6IL1CjP015639@elgar.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox