From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31510 invoked by alias); 18 Jul 2005 21:01:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31494 invoked by uid 22791); 18 Jul 2005 21:01:19 -0000 Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 18 Jul 2005 21:01:19 +0000 Received: from elgar.sibelius.xs4all.nl (root@elgar.sibelius.xs4all.nl [192.168.0.2]) by sibelius.xs4all.nl (8.13.0/8.13.0) with ESMTP id j6IL1Dlb026094 for ; Mon, 18 Jul 2005 23:01:13 +0200 (CEST) Received: from elgar.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by elgar.sibelius.xs4all.nl (8.13.4/8.13.3) with ESMTP id j6IL1DiY017577 for ; Mon, 18 Jul 2005 23:01:13 +0200 (CEST) Received: (from kettenis@localhost) by elgar.sibelius.xs4all.nl (8.13.4/8.13.4/Submit) id j6IL1CjP015639; Mon, 18 Jul 2005 23:01:12 +0200 (CEST) Date: Mon, 18 Jul 2005 21:01:00 -0000 Message-Id: <200507182101.j6IL1CjP015639@elgar.sibelius.xs4all.nl> From: Mark Kettenis To: gdb-patches@sourceware.org Subject: [commit] Use xsnprint for xxx_pid_to_str() X-SW-Source: 2005-07/txt/msg00158.txt.bz2 Small simplification now that we have xsnprintf. Please do something similar to your favourite code if it doesn't use this idiom yet. Committed, Mark Index: ChangeLog from Mark Kettenis * target.c (normal_pid_to_str): Use xsnprintf instead of snprintf. * bsd-uthread.c (bsd_uthread_pid_to_str): Likewise. * inf-ttrace.c (inf_ttrace_pid_to_str): Likewise. Index: target.c =================================================================== RCS file: /cvs/src/src/gdb/target.c,v retrieving revision 1.109 diff -u -p -r1.109 target.c --- target.c 28 May 2005 16:44:29 -0000 1.109 +++ target.c 18 Jul 2005 20:51:40 -0000 @@ -1793,10 +1793,8 @@ char * normal_pid_to_str (ptid_t ptid) { static char buf[32]; - int size; - size = snprintf (buf, sizeof buf, "process %d", ptid_get_pid (ptid)); - gdb_assert (size < sizeof buf); + xsnprintf (buf, sizeof buf, "process %d", ptid_get_pid (ptid)); return buf; } Index: bsd-uthread.c =================================================================== RCS file: /cvs/src/src/gdb/bsd-uthread.c,v retrieving revision 1.5 diff -u -p -r1.5 bsd-uthread.c --- bsd-uthread.c 4 Jul 2005 13:38:55 -0000 1.5 +++ bsd-uthread.c 18 Jul 2005 20:51:40 -0000 @@ -469,11 +469,9 @@ bsd_uthread_pid_to_str (ptid_t ptid) if (ptid_get_tid (ptid) != 0) { static char buf[64]; - int size; - size = snprintf (buf, sizeof buf, "process %d, thread 0x%lx", - ptid_get_pid (ptid), ptid_get_tid (ptid)); - gdb_assert (size < sizeof buf); + xsnprintf (buf, sizeof buf, "process %d, thread 0x%lx", + ptid_get_pid (ptid), ptid_get_tid (ptid)); return buf; } Index: inf-ttrace.c =================================================================== RCS file: /cvs/src/src/gdb/inf-ttrace.c,v retrieving revision 1.10 diff -u -p -r1.10 inf-ttrace.c --- inf-ttrace.c 21 Jun 2005 11:58:39 -0000 1.10 +++ inf-ttrace.c 18 Jul 2005 20:51:40 -0000 @@ -909,11 +909,9 @@ inf_ttrace_pid_to_str (ptid_t ptid) pid_t pid = ptid_get_pid (ptid); lwpid_t lwpid = ptid_get_lwp (ptid); static char buf[128]; - int size; - size = snprintf (buf, sizeof buf, "process %ld, lwp %ld", - (long)pid, (long)lwpid); - gdb_assert (size < sizeof buf); + xsnprintf (buf, sizeof buf, "process %ld, lwp %ld", + (long)pid, (long)lwpid); return buf; }