From: Daniel Jacobowitz <drow@false.org>
To: Steve Ellcey <sje@cup.hp.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Patch for gdb/configure cleanup (autoheader warnings)
Date: Sun, 03 Jul 2005 15:39:00 -0000 [thread overview]
Message-ID: <20050703153915.GA12669@nevyn.them.org> (raw)
In-Reply-To: <200507031533.IAA19791@hpsje.cup.hp.com>
On Sun, Jul 03, 2005 at 08:33:37AM -0700, Steve Ellcey wrote:
> OK, here is the patch again with the changelog file updated (all I added
> was the comment after 'configure.ac:'. There are too many AC_DEFINE
> statments changed to list them all. There were no changes to
> configure.ac other than adding the 2nd and 3rd arguments to the
> AC_DEFINE calls.
>
> As for XM_FILE, I am willing to kill it, but I would rather do that in a
> separate patch so why don't I leave it here and I can then do a new
> patch to remove it completely from the various config, header, and C
> files.
Definitely. This patch is OK.
> 2005-07-01 Steve Ellcey <sje@cup.hp.com>
>
> * configure.ac (AC_DEFINE): Add args to AC_DEFINE calls.
Please use this instead:
* configure.ac: Add arguments to AC_DEFINE calls.
You aren't changing AC_DEFINE itself.
> * acconfig.h: Remove file.
> * acinclude.m4 (AC_GNU_SOURCE): Remove definition.
> * configure: Regenerate.
> * config.in: Regenerate.
--
Daniel Jacobowitz
CodeSourcery, LLC
prev parent reply other threads:[~2005-07-03 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-01 23:10 Steve Ellcey
2005-07-02 1:39 ` Daniel Jacobowitz
2005-07-03 15:33 ` Steve Ellcey
2005-07-03 15:39 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050703153915.GA12669@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=sje@cup.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox