From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11403 invoked by alias); 3 Jul 2005 15:39:20 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11366 invoked by uid 22791); 3 Jul 2005 15:39:16 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Sun, 03 Jul 2005 15:39:16 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1Dp6Yt-0003K6-7X; Sun, 03 Jul 2005 11:39:15 -0400 Date: Sun, 03 Jul 2005 15:39:00 -0000 From: Daniel Jacobowitz To: Steve Ellcey Cc: gdb-patches@sourceware.org Subject: Re: Patch for gdb/configure cleanup (autoheader warnings) Message-ID: <20050703153915.GA12669@nevyn.them.org> Mail-Followup-To: Steve Ellcey , gdb-patches@sourceware.org References: <20050702013901.GA2389@nevyn.them.org> <200507031533.IAA19791@hpsje.cup.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200507031533.IAA19791@hpsje.cup.hp.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-07/txt/msg00016.txt.bz2 On Sun, Jul 03, 2005 at 08:33:37AM -0700, Steve Ellcey wrote: > OK, here is the patch again with the changelog file updated (all I added > was the comment after 'configure.ac:'. There are too many AC_DEFINE > statments changed to list them all. There were no changes to > configure.ac other than adding the 2nd and 3rd arguments to the > AC_DEFINE calls. > > As for XM_FILE, I am willing to kill it, but I would rather do that in a > separate patch so why don't I leave it here and I can then do a new > patch to remove it completely from the various config, header, and C > files. Definitely. This patch is OK. > 2005-07-01 Steve Ellcey > > * configure.ac (AC_DEFINE): Add args to AC_DEFINE calls. Please use this instead: * configure.ac: Add arguments to AC_DEFINE calls. You aren't changing AC_DEFINE itself. > * acconfig.h: Remove file. > * acinclude.m4 (AC_GNU_SOURCE): Remove definition. > * configure: Regenerate. > * config.in: Regenerate. -- Daniel Jacobowitz CodeSourcery, LLC