From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] mi-stack.exp
Date: Mon, 20 Jun 2005 01:34:00 -0000 [thread overview]
Message-ID: <20050620013409.GB30942@nevyn.them.org> (raw)
In-Reply-To: <17078.5246.665299.878084@farnswood.snap.net.nz>
On Mon, Jun 20, 2005 at 12:57:34PM +1200, Nick Roberts wrote:
> 2005-06-20 Nick Roberts <nickrob@snap.net.nz>
>
> * gdb.mi/mi-stack.exp (test_stack_locals_listing):
> Remove test for -stack-select-frame without arguments.
> (test_stack_frame_listing):
> Add test for newly implemented command -stack-info-frame.
OK. Please wrap it this way:
* gdb.mi/mi-stack.exp (test_stack_locals_listing): Remove test for
-stack-select-frame without arguments.
(test_stack_frame_listing): Add test for newly implemented command
-stack-info-frame.
> *** /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp.~1.15.~ 2005-05-18 20:18:15.000000000 +1200
> --- /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp 2005-06-19 18:49:18.000000000 +1200
Could you see about submitting relative diffs? It doesn't really
matter what they're relative _to_ - common is -p0 or -p1 to the top
directory whose ChangeLog you're touching. But this is a bit awkward
to apply.
As an aside, if you don't mind, please check in patches all at once.
When you check in each file separately with its own log message,
automated tools can't reconstruct the entire change.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-06-20 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 0:57 Nick Roberts
2005-06-20 1:34 ` Daniel Jacobowitz [this message]
2005-06-20 3:28 ` Nick Roberts
2005-06-20 3:00 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050620013409.GB30942@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox