From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9181 invoked by alias); 20 Jun 2005 01:34:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9162 invoked by uid 22791); 20 Jun 2005 01:34:10 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 20 Jun 2005 01:34:10 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1DkBAv-00085i-8S; Sun, 19 Jun 2005 21:34:09 -0400 Date: Mon, 20 Jun 2005 01:34:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] mi-stack.exp Message-ID: <20050620013409.GB30942@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17078.5246.665299.878084@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17078.5246.665299.878084@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00306.txt.bz2 On Mon, Jun 20, 2005 at 12:57:34PM +1200, Nick Roberts wrote: > 2005-06-20 Nick Roberts > > * gdb.mi/mi-stack.exp (test_stack_locals_listing): > Remove test for -stack-select-frame without arguments. > (test_stack_frame_listing): > Add test for newly implemented command -stack-info-frame. OK. Please wrap it this way: * gdb.mi/mi-stack.exp (test_stack_locals_listing): Remove test for -stack-select-frame without arguments. (test_stack_frame_listing): Add test for newly implemented command -stack-info-frame. > *** /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp.~1.15.~ 2005-05-18 20:18:15.000000000 +1200 > --- /home/nick/src/gdb/testsuite/gdb.mi/mi-stack.exp 2005-06-19 18:49:18.000000000 +1200 Could you see about submitting relative diffs? It doesn't really matter what they're relative _to_ - common is -p0 or -p1 to the top directory whose ChangeLog you're touching. But this is a bit awkward to apply. As an aside, if you don't mind, please check in patches all at once. When you check in each file separately with its own log message, automated tools can't reconstruct the entire change. -- Daniel Jacobowitz CodeSourcery, LLC