From: Daniel Jacobowitz <drow@false.org>
To: Wu Zhou <woodzltc@cn.ibm.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Add code to support evaluating Fortran exponentiation expression
Date: Fri, 17 Jun 2005 13:41:00 -0000 [thread overview]
Message-ID: <20050617134139.GC23901@nevyn.them.org> (raw)
In-Reply-To: <Pine.LNX.4.63.0506171316270.15833@localhost.localdomain>
On Fri, Jun 17, 2005 at 01:22:26PM +0800, Wu Zhou wrote:
> 2005-06-17 Wu Zhou <woodzltc@cn.ibm.com>
>
> * f-exp.y (yyparse): Add code to support exponentiation expression.
> (yylex): Add code to scan exponentiation operator.
> * eval.c (evaluate_subexp_standard): Add support for BINOP_EXP.
> * valarith.c (value_binop): Reset errno to 0 before calling pow
> to do exponentiation operation.
This will need a testcase, in addition to documentation. Doing those
separately is fine. The only other problem is that f-exp.y needs a
copyright year update: the last listed year is 2001, but I see it has
been modified in 2002, 2003, and 2004. So please add all of those
years (plus 2005).
Otherwise OK.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-06-17 13:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-17 7:36 Wu Zhou
2005-06-17 10:17 ` Eli Zaretskii
2005-06-20 3:47 ` Wu Zhou
2005-06-20 19:08 ` Eli Zaretskii
2005-06-21 14:32 ` Wu Zhou
2005-06-21 19:41 ` Eli Zaretskii
2005-06-17 13:41 ` Daniel Jacobowitz [this message]
2005-06-20 4:00 ` Wu Zhou
2005-07-03 17:07 ` Daniel Jacobowitz
2005-07-06 8:55 ` Wu Zhou
2005-06-20 4:14 ` Wu Zhou
2005-07-03 17:05 ` Daniel Jacobowitz
2005-07-06 8:36 ` Wu Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050617134139.GC23901@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=woodzltc@cn.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox