From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18267 invoked by alias); 17 Jun 2005 13:41:53 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18204 invoked by uid 22791); 17 Jun 2005 13:41:41 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Fri, 17 Jun 2005 13:41:41 +0000 Received: from drow by nevyn.them.org with local (Exim 4.51) id 1DjH6J-0006M6-M1; Fri, 17 Jun 2005 09:41:39 -0400 Date: Fri, 17 Jun 2005 13:41:00 -0000 From: Daniel Jacobowitz To: Wu Zhou Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Add code to support evaluating Fortran exponentiation expression Message-ID: <20050617134139.GC23901@nevyn.them.org> Mail-Followup-To: Wu Zhou , gdb-patches@sources.redhat.com References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00256.txt.bz2 On Fri, Jun 17, 2005 at 01:22:26PM +0800, Wu Zhou wrote: > 2005-06-17 Wu Zhou > > * f-exp.y (yyparse): Add code to support exponentiation expression. > (yylex): Add code to scan exponentiation operator. > * eval.c (evaluate_subexp_standard): Add support for BINOP_EXP. > * valarith.c (value_binop): Reset errno to 0 before calling pow > to do exponentiation operation. This will need a testcase, in addition to documentation. Doing those separately is fine. The only other problem is that f-exp.y needs a copyright year update: the last listed year is 2001, but I see it has been modified in 2002, 2003, and 2004. So please add all of those years (plus 2005). Otherwise OK. -- Daniel Jacobowitz CodeSourcery, LLC