Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] -stack-select-frame
Date: Thu, 16 Jun 2005 04:42:00 -0000	[thread overview]
Message-ID: <20050616044209.GA5907@nevyn.them.org> (raw)
In-Reply-To: <17072.62436.183299.55978@farnswood.snap.net.nz>

On Thu, Jun 16, 2005 at 03:37:08PM +1200, Nick Roberts wrote:
> 
> Last year I submitted a dreadful patch for -stack-select-frame
> (thread subject: How does GDB/MI give the current frame).
> 
> Here, hopefully, is a much more sensible one.  The idea is the same: that
> -stack-select-frame tells the frontend what the current or selected frame
> is.
> 
> The current documentation for -stack-select-frame is slightly wrong because
> the argument FRAMENUM is optional.  I've corrected this and explained what
> the patch does.

- You're changing the behavior of a command; do people use this
command?  Are you confident that they will handle the new output
gracefully?

- Please, let's not add new MI features without matching testcases.

> ! ^done,frame=@{level="2",addr="0x000107a4",func="foo",
> !   file="recursive2.c",fullname="/home/foo/bar/devo/myproject/recursive2.c",line=line="14"@},

The double line= is a typo, right?

-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-06-16  4:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-16  3:36 Nick Roberts
2005-06-16  4:42 ` Daniel Jacobowitz [this message]
2005-06-16  6:41   ` Nick Roberts
2005-06-16 13:21     ` Daniel Jacobowitz
2005-06-16 22:58       ` Nick Roberts
2005-06-16 23:20         ` Bob Rossi
2005-06-16 23:47         ` Daniel Jacobowitz
2005-06-17  3:07           ` Nick Roberts
2005-06-17  3:21             ` Daniel Jacobowitz
2005-06-17  7:37               ` Nick Roberts
2005-06-17 10:15                 ` Eli Zaretskii
2005-06-17 13:33                   ` Daniel Jacobowitz
2005-06-18  8:56                     ` Eli Zaretskii
2005-06-17  9:55               ` Eli Zaretskii
2005-06-17  9:46             ` Eli Zaretskii
2005-06-16 18:23 ` Eli Zaretskii
2005-06-16 20:15 ` Jason Molenda
2005-06-16 23:04   ` Nick Roberts
2005-06-16 23:30     ` Jason Molenda
2005-06-17  7:22       ` Nick Roberts
2005-06-17 13:30         ` Daniel Jacobowitz
2005-06-17 19:48         ` Jason Molenda
2005-06-17 22:35         ` Stan Shebs
2005-06-17 22:59           ` Daniel Jacobowitz
2005-06-17 23:31           ` Nick Roberts
     [not found] <1119003319.5434.ezmlm@sources.redhat.com>
2005-06-17 17:45 ` Jim Ingham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050616044209.GA5907@nevyn.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox