From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13036 invoked by alias); 16 Jun 2005 04:42:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13026 invoked by uid 22791); 16 Jun 2005 04:42:11 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Thu, 16 Jun 2005 04:42:11 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DimCf-0001Xt-HE; Thu, 16 Jun 2005 00:42:09 -0400 Date: Thu, 16 Jun 2005 04:42:00 -0000 From: Daniel Jacobowitz To: Nick Roberts Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] -stack-select-frame Message-ID: <20050616044209.GA5907@nevyn.them.org> Mail-Followup-To: Nick Roberts , gdb-patches@sources.redhat.com References: <17072.62436.183299.55978@farnswood.snap.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17072.62436.183299.55978@farnswood.snap.net.nz> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00216.txt.bz2 On Thu, Jun 16, 2005 at 03:37:08PM +1200, Nick Roberts wrote: > > Last year I submitted a dreadful patch for -stack-select-frame > (thread subject: How does GDB/MI give the current frame). > > Here, hopefully, is a much more sensible one. The idea is the same: that > -stack-select-frame tells the frontend what the current or selected frame > is. > > The current documentation for -stack-select-frame is slightly wrong because > the argument FRAMENUM is optional. I've corrected this and explained what > the patch does. - You're changing the behavior of a command; do people use this command? Are you confident that they will handle the new output gracefully? - Please, let's not add new MI features without matching testcases. > ! ^done,frame=@{level="2",addr="0x000107a4",func="foo", > ! file="recursive2.c",fullname="/home/foo/bar/devo/myproject/recursive2.c",line=line="14"@}, The double line= is a typo, right? -- Daniel Jacobowitz CodeSourcery, LLC