From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/hppa] Can not insert breakpoint at address higher than 0xFFFFFF
Date: Mon, 13 Jun 2005 03:23:00 -0000 [thread overview]
Message-ID: <20050613032349.GI9288@nevyn.them.org> (raw)
In-Reply-To: <20050603235918.GD1266@adacore.com>
Oops, thought I reviewed this one earlier...
On Fri, Jun 03, 2005 at 04:59:18PM -0700, Joel Brobecker wrote:
> The problem is that the program built by our customer is large enough
> that the address of certain symbol exceeds 0xFFFFFF, and hence triggers
> the condition above.
>
> But the condition above doesn't correspond to the comment. We think it
> is an error, although it's always hard to tell with a hack. Anyway,
> if changed the check to make sure that *all* bits in the top byte are
> 1's before forcing the user to start the program for this breakpoint.
> This fixes the problem.
>
> 2005-06-03 Joel Brobecker <brobecker@adacore.com>
>
> * hppa-tdep.c (hppa_pc_requires_run_before_use): Really test all
> bits in of type byte in address.
>
> Tested on hppa-hpux, no regression.
> OK to apply?
Yes, I agree with your reading. This is OK.
--
Daniel Jacobowitz
CodeSourcery, LLC
next prev parent reply other threads:[~2005-06-13 3:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 23:59 Joel Brobecker
2005-06-13 3:23 ` Daniel Jacobowitz [this message]
2005-06-13 13:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050613032349.GI9288@nevyn.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox