From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18111 invoked by alias); 13 Jun 2005 03:23:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18101 invoked by uid 22791); 13 Jun 2005 03:23:51 -0000 Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.30-dev) with ESMTP; Mon, 13 Jun 2005 03:23:51 +0000 Received: from drow by nevyn.them.org with local (Exim 4.50) id 1DhfYD-0006X3-6f; Sun, 12 Jun 2005 23:23:49 -0400 Date: Mon, 13 Jun 2005 03:23:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA/hppa] Can not insert breakpoint at address higher than 0xFFFFFF Message-ID: <20050613032349.GI9288@nevyn.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sources.redhat.com References: <20050603235918.GD1266@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050603235918.GD1266@adacore.com> User-Agent: Mutt/1.5.8i X-SW-Source: 2005-06/txt/msg00144.txt.bz2 Oops, thought I reviewed this one earlier... On Fri, Jun 03, 2005 at 04:59:18PM -0700, Joel Brobecker wrote: > The problem is that the program built by our customer is large enough > that the address of certain symbol exceeds 0xFFFFFF, and hence triggers > the condition above. > > But the condition above doesn't correspond to the comment. We think it > is an error, although it's always hard to tell with a hack. Anyway, > if changed the check to make sure that *all* bits in the top byte are > 1's before forcing the user to start the program for this breakpoint. > This fixes the problem. > > 2005-06-03 Joel Brobecker > > * hppa-tdep.c (hppa_pc_requires_run_before_use): Really test all > bits in of type byte in address. > > Tested on hppa-hpux, no regression. > OK to apply? Yes, I agree with your reading. This is OK. -- Daniel Jacobowitz CodeSourcery, LLC